fix: Backport SVG filter invalidation fix from Chromium #27635
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deepak1556
added
11-x-y
backport-check-skip
deepak1556
requested changes
Feb 5, 2021
patches/chromium/fix_svg_filter_data_invalidation_for_empty_containers.patch
Outdated
Show resolved
Hide resolved
rzhao271
force-pushed
the
rzhao271/fix-svg-patch
branch
from
4dd1f4d
to
69ae460
Compare
deepak1556
reviewed
Feb 5, 2021
patches/chromium/fix_svg_filter_data_invalidation_for_empty_containers.patch
Outdated
Show resolved
Hide resolved
rzhao271
force-pushed
the
rzhao271/fix-svg-patch
branch
from
bfad173
to
2a524c3
Compare
deepak1556
approved these changes
Feb 5, 2021
deepak1556
approved these changes
Feb 5, 2021
jkleinsc
approved these changes
Feb 8, 2021
|
Merging as CI failure is flake unrelated to this PR. |
|
Congrats on merging your first pull request! 🎉🎉🎉 |
|
Release Notes Persisted
|
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
This is a backport of an upstream fix that is already in Electron v12.0.0-beta.16 and newer.
Downstream issue:
microsoft/vscode#112693
In a VS Code, an SVG produced by a notebook wasn't rendering on time.
Diff to backport from Chromium:
https://chromium.googlesource.com/chromium/src/+/15a8dbe6efe865eaaae63b48b6a3bacd3420a89b%5E%21/
There was an SVG rendering glitch in Chromium where invalidate wasn't getting called in some cases.
CC @deepak1556
Checklist
npm testpassesRelease Notes
Notes: Fix svg with filter content not being rendered