Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Avoid crashing in NativeViewHost::SetParentAccessible on Windows 10 #26949

Merged
merged 3 commits into from Dec 11, 2020
Merged

fix: Avoid crashing in NativeViewHost::SetParentAccessible on Windows 10 #26949

merged 3 commits into from Dec 11, 2020

Commits on Dec 11, 2020

  1. fix: Avoid crashing in NativeViewHost::SetParentAccessible on Windows 

    This fixes #26905. The patch was obtained from @deepak1556, who in turn
got it from the Microsoft Teams folks.

I believe the crash started happening due to the changes in
https://chromium.googlesource.com/chromium/src.git/+/5c6c8e994bce2bfb867279ae5068e9f9134e70c3%5E!/#F15

This affects Electron 9 and later.

Notes: Fix occasional crash on Windows
    @poiru @electron-bot
    poiru authored and electron-bot committed Dec 11, 2020
    Copy the full SHA
    b174a32 View commit details
    Browse the repository at this point in the history

  2. Update .patches

    @nornagon
    nornagon committed Dec 11, 2020
    Copy the full SHA
    7edc8ff View commit details
    Browse the repository at this point in the history

  3. update patches

    @electron-bot
    electron-bot committed Dec 11, 2020
    Copy the full SHA
    8ac73fd View commit details
    Browse the repository at this point in the history