Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: stack traces in non-Node.js contexts #26912

Merged
merged 1 commit into from
Dec 14, 2020
Merged

fix: stack traces in non-Node.js contexts #26912

merged 1 commit into from
Dec 14, 2020

Conversation

trop[bot]
Copy link
Contributor

@trop trop bot commented Dec 9, 2020

Backport of #26820

See that PR for details.

Notes: Fixed an issue where renderer process stack traces were broken with contextIsolation enabled.

@trop trop bot requested a review from a team as a code owner December 9, 2020 19:08
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Dec 9, 2020
@trop trop bot requested a review from codebytere December 9, 2020 19:08
@trop trop bot mentioned this pull request Dec 9, 2020
Merged
3 tasks
@trop trop bot added 12-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes labels Dec 9, 2020
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Dec 9, 2020
@jkleinsc
Copy link
Contributor

Merging as CI failure is known flake unrelated to PR change.

@jkleinsc jkleinsc merged commit fe022df into 12-x-y Dec 14, 2020
@release-clerk
Copy link

release-clerk bot commented Dec 14, 2020

Release Notes Persisted

Fixed an issue where renderer process stack traces were broken with contextIsolation enabled.

@trop trop bot deleted the trop/12-x-y-bp-fix-stack-traces-in-non-node-js-contexts-1607540918192 branch December 14, 2020 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkleinsc jkleinsc jkleinsc approved these changes

@codebytere codebytere codebytere approved these changes

Assignees
No one assigned
Labels
12-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jkleinsc @codebytere