Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: message box missing an "OK" button in GTK #26857

Merged
merged 1 commit into from
Dec 9, 2020
Merged

fix: message box missing an "OK" button in GTK #26857

merged 1 commit into from
Dec 9, 2020

Conversation

stevenjoezhang
Copy link
Contributor

@stevenjoezhang stevenjoezhang commented Dec 7, 2020 •
edited

Description of Change

The current behavior

截屏2020-12-07 下午5 47 50

The new behavior

截屏2020-12-07 下午5 47 08

Tests: https://github.com/stevenjoezhang/electron-quick-start
Issue resolved: #26482
See also #2145
Ref https://developer.gnome.org/gtk3/stable/GtkMessageDialog.html#gtk-message-dialog-new

Checklist

Release Notes

Notes: Fixed an issue that a message box in GTK contains no buttons.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Dec 7, 2020
codebytere
codebytere approved these changes Dec 7, 2020
View reviewed changes
Copy link
Member

@codebytere codebytere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@codebytere codebytere requested a review from ckerr December 7, 2020 17:15
@codebytere codebytere added semver/patch backwards-compatible bug fixes target/10-x-y labels Dec 7, 2020
@stevenjoezhang stevenjoezhang mentioned this pull request Dec 8, 2020
Closed
3 tasks
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Dec 8, 2020
@zcbenz zcbenz merged commit 9908cc3 into electron:master Dec 9, 2020
@release-clerk
Copy link

release-clerk bot commented Dec 9, 2020

Release Notes Persisted

Fixed an issue that a message box in GTK contains no buttons.

This was referenced Dec 9, 2020
Merged
Merged
Merged
@trop
Copy link
Contributor

trop bot commented Dec 9, 2020

I have automatically backported this PR to "10-x-y", please check out #26915

@trop
Copy link
Contributor

trop bot commented Dec 9, 2020

I have automatically backported this PR to "11-x-y", please check out #26916

@trop
Copy link
Contributor

trop bot commented Dec 9, 2020

I have automatically backported this PR to "12-x-y", please check out #26917

@stevenjoezhang stevenjoezhang deleted the gtk-message-box branch December 10, 2020 02:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zcbenz zcbenz zcbenz approved these changes

@codebytere codebytere codebytere approved these changes

@ckerr ckerr Awaiting requested review from ckerr

Assignees
No one assigned
Labels
semver/patch backwards-compatible bug fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Message box missing a close button on Ubuntu
3 participants
@stevenjoezhang @zcbenz @codebytere