Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: send IPC_MESSAGES.RENDERER_RELEASE_CALLBACK as internal message #26836

Merged
merged 1 commit into from Dec 8, 2020
Merged

fix: send IPC_MESSAGES.RENDERER_RELEASE_CALLBACK as internal message #26836

merged 1 commit into from Dec 8, 2020

Conversation

miniak
Copy link
Contributor

@miniak miniak commented Dec 4, 2020

Backport of #26808

See that PR for details.

Notes: Fixed callbacks passed via the remote module not being released after all references are dropped.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Dec 4, 2020
@trop trop bot mentioned this pull request Dec 4, 2020
Merged
3 tasks
@trop trop bot added 11-x-y backport This is a backport PR labels Dec 4, 2020
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Dec 4, 2020
@miniak miniak self-assigned this Dec 4, 2020
@miniak miniak requested a review from nornagon December 4, 2020 22:22
@codebytere
Copy link
Member

@miniak this is failing on TypeScript compilation

@miniak miniak force-pushed the miniak/fix-remote-release-callback-11-x-y branch from d79f68e to 8e55e49 Compare December 8, 2020 03:16
@miniak
Copy link
Contributor Author

miniak commented Dec 8, 2020

@codebytere fixed

@miniak miniak added the semver/patch backwards-compatible bug fixes label Dec 8, 2020
@zcbenz zcbenz merged commit 2c325cd into 11-x-y Dec 8, 2020
@release-clerk
Copy link

release-clerk bot commented Dec 8, 2020

Release Notes Persisted

Fixed callbacks passed via the remote module not being released after all references are dropped.

@zcbenz zcbenz deleted the miniak/fix-remote-release-callback-11-x-y branch December 8, 2020 04:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zcbenz zcbenz zcbenz approved these changes

@nornagon nornagon Awaiting requested review from nornagon

Assignees

@miniak miniak

Labels
11-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@miniak @codebytere @zcbenz