Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add a "set" trap to the "screen" module proxy #26818

Merged
merged 2 commits into from
Dec 7, 2020
Merged

fix: add a "set" trap to the "screen" module proxy #26818

merged 2 commits into from
Dec 7, 2020

Conversation

alexeykuzmin
Copy link
Contributor

@alexeykuzmin alexeykuzmin commented Dec 3, 2020 •
edited

Description of Change

Let's make it possible to stub screen methods for testing.

Checklist

Release Notes

Notes: Fixed "screen" methods to be reassignable again.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Dec 3, 2020
@alexeykuzmin alexeykuzmin changed the title chore: support "set" for the Screen proxy fix: add a "set" trap to the "screen" module proxy Dec 4, 2020
@alexeykuzmin alexeykuzmin force-pushed the alkuzmin/set-for-proxy branch 2 times, most recently from e58dea6 to 2391845 Compare December 4, 2020 15:30
@alexeykuzmin alexeykuzmin added target/11-x-y semver/patch backwards-compatible bug fixes labels Dec 4, 2020
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Dec 4, 2020
@alexeykuzmin alexeykuzmin removed the semver/patch backwards-compatible bug fixes label Dec 5, 2020
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Dec 5, 2020
@alexeykuzmin alexeykuzmin added the semver/patch backwards-compatible bug fixes label Dec 5, 2020
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Dec 5, 2020
@codebytere codebytere merged commit e89b3ca into master Dec 7, 2020
@release-clerk
Copy link

release-clerk bot commented Dec 7, 2020

Release Notes Persisted

Fixed "screen" methods to be reassignable again.

@codebytere codebytere deleted the alkuzmin/set-for-proxy branch December 7, 2020 17:20
@trop
Copy link
Contributor

trop bot commented Dec 7, 2020

I was unable to backport this PR to "11-x-y" cleanly;
you will need to perform this backport manually.

@trop trop bot mentioned this pull request Dec 7, 2020
Merged
@trop
Copy link
Contributor

trop bot commented Dec 7, 2020

I have automatically backported this PR to "12-x-y", please check out #26868

@0501814314
Copy link

Mosa.homdi2013@gmail.com

@0501814314
Copy link

Mosa.homdi2013@gmail.com

@alexeykuzmin alexeykuzmin mentioned this pull request Dec 7, 2020
Merged
@trop
Copy link
Contributor

trop bot commented Dec 7, 2020

@alexeykuzmin has manually backported this PR to "11-x-y", please check out #26873

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nornagon nornagon nornagon left review comments

@miniak miniak miniak approved these changes

@codebytere codebytere codebytere approved these changes

Assignees
No one assigned
Labels
semver/patch backwards-compatible bug fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@alexeykuzmin @0501814314 @nornagon @miniak @codebytere