feat: add event.senderFrame property returning the webFrameMain #26764

miniak · 2020-12-01T18:28:54Z

Description of Change

Also add missing event.processId, which needs to be passed to webFrameMain.fromId().

Checklist

PR description included and stakeholders cc'd
npm test passes
tests are changed or added
relevant documentation is changed or added
PR release notes describe the change in a way relevant to app developers, and are capitalized, punctuated, and past tense.

Release Notes

Notes: Added event.senderFrame property returning the originating webFrameMain of the IPC message.

docs/api/structures/ipc-main-event.md

docs/api/web-frame-main.md

lib/browser/api/web-contents.ts

nornagon

API LGTM

samuelmaddock

The getter is going to be very handy. Nice!

samuelmaddock · 2020-12-02T01:21:38Z

lib/browser/api/web-contents.ts

+  Object.defineProperty(event, 'senderFrame', {
+    get: () => webFrameMain.fromId(processId, frameId)
+  });
+};


This is great!

jkleinsc

API LGTM as well

miniak · 2020-12-09T00:28:03Z

@nornagon I've noticed that, I had it originally

    dict.Set("processId", frame->GetProcess()->GetID());
    dict.Set("frameId", frame->GetRoutingID());

and then changed it to match your PR to avoid conflict

    dict.Set("frameId", frame->GetRoutingID());
    dict.Set("processId", frame->GetProcess()->GetID());

which broke the snapshot for tests

nornagon · 2020-12-09T00:44:20Z

@miniak the linked PR updates the tests to replace the process id with a placeholder in the snapshot.

…meMain

release-clerk · 2020-12-09T23:34:10Z

Release Notes Persisted

Added event.senderFrame property returning the originating webFrameMain of the IPC message.

trop · 2020-12-09T23:34:19Z

I was unable to backport this PR to "12-x-y" cleanly;
you will need to perform this backport manually.

miniak · 2020-12-16T16:31:47Z

/trop run backport-to 12-x-y

trop · 2020-12-16T16:31:49Z

The backport process for this PR has been manually initiated -
sending your commits to "12-x-y"!

trop · 2020-12-16T16:32:05Z

I was unable to backport this PR to "12-x-y" cleanly;
you will need to perform this backport manually.

…meMain (#26764)

trop · 2020-12-16T17:33:52Z

@miniak has manually backported this PR to "12-x-y", please check out #27047

…meMain (#26764) (#27047)

electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Dec 1, 2020

miniak force-pushed the miniak/event-process-id branch from 062ab59 to 2ef55ad Compare December 1, 2020 18:46

miniak marked this pull request as ready for review December 1, 2020 18:47

miniak requested review from nornagon, samuelmaddock and zcbenz December 1, 2020 18:49

nornagon added api-review/requested 🗳 semver/minor backwards-compatible functionality labels Dec 1, 2020

miniak force-pushed the miniak/event-process-id branch from 2ef55ad to 99e552d Compare December 1, 2020 19:10

miniak changed the title ~~feat: add event.processId to be usable with webFrameMain.fromId()~~ feat: add event.frame property returning the originating webFrameMain Dec 1, 2020

miniak force-pushed the miniak/event-process-id branch 3 times, most recently from 80275f0 to 5da8a4d Compare December 1, 2020 19:40

miniak changed the title ~~feat: add event.frame property returning the originating webFrameMain~~ feat: add event.senderFrame property returning the webFrameMain Dec 1, 2020

miniak force-pushed the miniak/event-process-id branch from 5da8a4d to c0f074b Compare December 1, 2020 19:46

miniak self-assigned this Dec 1, 2020

miniak force-pushed the miniak/event-process-id branch from c0f074b to 6eb5079 Compare December 1, 2020 21:31

nornagon requested changes Dec 1, 2020

View reviewed changes

docs/api/structures/ipc-main-event.md Outdated Show resolved Hide resolved

docs/api/web-frame-main.md Show resolved Hide resolved

lib/browser/api/web-contents.ts Outdated Show resolved Hide resolved

nornagon added the target/12-x-y label Dec 2, 2020

miniak force-pushed the miniak/event-process-id branch from d45e7c3 to 6c0b2e2 Compare December 2, 2020 00:10

nornagon approved these changes Dec 2, 2020

View reviewed changes

miniak force-pushed the miniak/event-process-id branch from 6c0b2e2 to 0660412 Compare December 2, 2020 00:17

samuelmaddock approved these changes Dec 2, 2020

View reviewed changes

miniak force-pushed the miniak/event-process-id branch 2 times, most recently from 83f8c74 to 0cac7e2 Compare December 2, 2020 02:12

jkleinsc approved these changes Dec 2, 2020

View reviewed changes

electron-cation bot added new-pr 🌱 PR opened in the last 24 hours and removed new-pr 🌱 PR opened in the last 24 hours labels Dec 2, 2020

miniak force-pushed the miniak/event-process-id branch from 0cac7e2 to 5bd5f19 Compare December 3, 2020 17:29

MarshallOfSound removed the api-review/requested 🗳 label Dec 3, 2020

electron-cation bot added api-review/approved ✅ and removed api-review/requested 🗳 labels Dec 9, 2020

miniak force-pushed the miniak/event-process-id branch from aea563c to c75859b Compare December 9, 2020 00:28

miniak force-pushed the miniak/event-process-id branch from c75859b to c1d6a57 Compare December 9, 2020 19:50

nornagon approved these changes Dec 9, 2020

View reviewed changes

feat: add event.senderFrame property returning the originating webFra…

4a814cd

…meMain

miniak force-pushed the miniak/event-process-id branch from c1d6a57 to 4a814cd Compare December 9, 2020 21:02

codebytere merged commit cec6378 into master Dec 9, 2020

codebytere deleted the miniak/event-process-id branch December 9, 2020 23:34

trop bot added needs-manual-bp/12-x-y and removed target/12-x-y labels Dec 9, 2020

miniak added a commit that referenced this pull request Dec 16, 2020

feat: add event.senderFrame property returning the originating webFra…

df33ccb

…meMain (#26764)

miniak mentioned this pull request Dec 16, 2020

feat: add event.senderFrame property returning the originating webFrameMain #27047

Merged

trop bot added in-flight/12-x-y and removed needs-manual-bp/12-x-y labels Dec 16, 2020

VerteDinde removed the api-review/approved ✅ label Dec 17, 2020

electron-cation bot added the api-review/approved ✅ label Dec 17, 2020

VerteDinde added the backport/approved ✅ label Dec 17, 2020

trop bot added merged/12-x-y and removed in-flight/12-x-y labels Jan 11, 2021

zcbenz pushed a commit that referenced this pull request Jan 11, 2021

feat: add event.senderFrame property returning the originating webFra…

f5af20d

…meMain (#26764) (#27047)

deepak1556 mentioned this pull request Apr 13, 2022

fix: apply senderFrame details to ipcMain port event #33756

Merged

5 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: add event.senderFrame property returning the webFrameMain #26764

feat: add event.senderFrame property returning the webFrameMain #26764

miniak commented Dec 1, 2020 •

edited

nornagon left a comment

samuelmaddock left a comment

samuelmaddock Dec 2, 2020

jkleinsc left a comment

miniak commented Dec 9, 2020

nornagon commented Dec 9, 2020

release-clerk bot commented Dec 9, 2020

trop bot commented Dec 9, 2020

miniak commented Dec 16, 2020

trop bot commented Dec 16, 2020

trop bot commented Dec 16, 2020

trop bot commented Dec 16, 2020

feat: add event.senderFrame property returning the webFrameMain #26764

feat: add event.senderFrame property returning the webFrameMain #26764

Conversation

miniak commented Dec 1, 2020 • edited

Description of Change

Checklist

Release Notes

nornagon left a comment

Choose a reason for hiding this comment

samuelmaddock left a comment

Choose a reason for hiding this comment

samuelmaddock Dec 2, 2020

Choose a reason for hiding this comment

jkleinsc left a comment

Choose a reason for hiding this comment

miniak commented Dec 9, 2020

nornagon commented Dec 9, 2020

release-clerk bot commented Dec 9, 2020

trop bot commented Dec 9, 2020

miniak commented Dec 16, 2020

trop bot commented Dec 16, 2020

trop bot commented Dec 16, 2020

trop bot commented Dec 16, 2020

miniak commented Dec 1, 2020 •

edited