fix: draggable views on BrowserViews on Windows #26738
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codebytere
force-pushed
the
browserview-drag-windows
branch
3 times, most recently
from
1ce963f
to
9cf1483
Compare
codebytere
force-pushed
the
browserview-drag-windows
branch
from
9cf1483
to
a9a02a9
Compare
ckerr
approved these changes
Dec 1, 2020
|
Release Notes Persisted
|
This was referenced Dec 1, 2020
|
I have automatically backported this PR to "11-x-y", please check out #26774 |
|
I have automatically backported this PR to "12-x-y", please check out #26775 |
|
@codebytere has manually backported this PR to "10-x-y", please check out #27222 |
3 tasks
| @@ -40,6 +48,8 @@ class NativeBrowserViewViews : public NativeBrowserView { | |||
| float auto_vertical_proportion_height_ = 0.; | |||
| float auto_vertical_proportion_top_ = 0.; | |||
|
|
|||
There was a problem hiding this comment.
where can I find -webkit-app-region parsing?
I wanna find out how Electron works if -webkit-app-region is applied.
@ckerr @codebytere @lsegal @vitaliel @anaisbetts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Closes #26562.
Prior to this PR draggable views did not work with BrowserViews except on macOS, which was fixed in #26145. This fixes that same functionality on Windows.
Tested with https://gist.github.com/7278c8c62ec976110afb47ef2d861a7a.
Checklist
npm testpassesRelease Notes
Notes: Fixed an issue where draggable regions did not work exclusively on BrowserViews on Windows.