Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: LC_ALL env should not be changed #26507

Merged
merged 1 commit into from Nov 18, 2020
Merged

fix: LC_ALL env should not be changed #26507

merged 1 commit into from Nov 18, 2020

Conversation

zcbenz
Copy link
Member

@zcbenz zcbenz commented Nov 16, 2020

Description of Change

Close #26443.

The LC_ALL env should not be changed when handling the --lang argument.

Checklist

Release Notes

Notes: Fix LC_ALL environment variable getting changed in Electron.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Nov 16, 2020
@zcbenz zcbenz mentioned this pull request Nov 16, 2020
Merged
@trop
Copy link
Contributor

trop bot commented Nov 16, 2020

@zcbenz has manually backported this PR to "9-x-y", please check out #26508

ckerr
ckerr approved these changes Nov 16, 2020
View reviewed changes
Copy link
Member

@ckerr ckerr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

shell/browser/electron_browser_main_parts.cc Show resolved Hide resolved
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Nov 17, 2020
@zcbenz zcbenz merged commit cc136f2 into master Nov 18, 2020
@release-clerk
Copy link

release-clerk bot commented Nov 18, 2020

Release Notes Persisted

Fix LC_ALL environment variable getting changed in Electron.

@zcbenz zcbenz deleted the fix-lc-all-env branch November 18, 2020 02:13
This was referenced Nov 18, 2020
Merged
Merged
@trop
Copy link
Contributor

trop bot commented Nov 18, 2020

I have automatically backported this PR to "10-x-y", please check out #26550

@trop
Copy link
Contributor

trop bot commented Nov 18, 2020

I have automatically backported this PR to "11-x-y", please check out #26551

@trop trop bot added merged/9-x-y and removed target/11-x-y labels Nov 18, 2020
@zcbenz zcbenz mentioned this pull request Nov 24, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ckerr ckerr ckerr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

LC_ALL set to invalid value
2 participants
@zcbenz @ckerr