fix: hover text only working when VO enabled

[codebytere]

Description of Change

Closes #25695.

Previously some screenreader-associated accessibility tooling was being enabled exclusively when VoiceOver was turned on, which broke Hover Text among some other things. This is because we only called ax_state->OnScreenReaderDetected(); if VoiceOver was enabled, and is fixed by removing that condition. The previous condition seems to have been added as a result of atom/atom#3288, but some local testing seems to ensure that text to speech still works after this removal.

cc @ckerr @jkleinsc @zcbenz

Checklist

• PR description included and stakeholders cc'd
• npm test passes
• PR release notes describe the change in a way relevant to app developers, and are capitalized, punctuated, and past tense.

Release Notes

Notes: Fixed an issue where Hover Text on macOS Catalina did not work without VoiceOver also being enabled.

[ckerr]

It looks like this behavior was introduced by 6bc59cf and one of the comments for that patch says

This looks like something has changed in Chrome. With the VoiceOver patch, I mimicked Chrome's behavior of enabling the accessibility tree when VoiceOver was active, and disabling the tree when inactive.

This comment is 5 years old so it's likely stale information, but just to check -- did you confirm that we're still tracking to how Chrome behaves wrt the accessibility tree?

[ckerr]

LGTM. Other than the addition of AXManualAccessibility, this matches what chrome_browser_application_mac.mm is doing.

[codebytere]

not ok 1330 webContents module render view deleted events does not emit current-render-view-deleted when speculative RVHs are deleted and nativeWindowOpen is set to true
  TypeError: Cannot read property 'webContents' of undefined
      at Timeout._onTimeout (electron\spec-main\api-web-contents-spec.ts:1213:21)
      at listOnTimeout (internal/timers.js:554:17)
      at processTimers (internal/timers.js:497:7)

failure is unrelated, merging.

[release-clerk]

Release Notes Persisted

Fixed an issue where Hover Text on macOS Catalina did not work without VoiceOver also being enabled.

[trop]

I have automatically backported this PR to "9-x-y", please check out #26244

[trop]

I have automatically backported this PR to "10-x-y", please check out #26245

[trop]

I have automatically backported this PR to "11-x-y", please check out #26246