perf: remove GC timer that fired once per minute. #25958
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nornagon
approved these changes
Oct 15, 2020
codebytere
approved these changes
Oct 15, 2020
jkleinsc
force-pushed
the
remove-periodic-GC-timer
branch
from
3c208f6
to
446acd3
Compare
zcbenz
approved these changes
Oct 20, 2020
|
No Release Notes |
This was referenced Oct 20, 2020
|
I have automatically backported this PR to "11-x-y", please check out #26051 |
|
I have automatically backported this PR to "10-x-y", please check out #26052 |
|
I have automatically backported this PR to "9-x-y", please check out #26053 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Fixes #25954
ElectronBrowserMainParts has a periodic timer that is used to trigger GC once a minute even on an idle system. While one wakeup per minute isn't bad, it's also been in there since 2014 and doesn't seem to be necessary.
This heartbeat doesn't seem to be necessary, at least for a simple system. I see no difference in memory use with or without this timer when running the default app for an hour.
Any review welcomed. CC'ing @nornagon as he commented on #25954
Checklist
npm testpassesRelease Notes
Notes: none.