chore: cherry-pick b1b3ccbd57 from chromium. #25852
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ppontes
force-pushed
the
ppontes/cherry-pick/10-x-y/chromium/7e42e0a7c6-n-b1b3ccbd57
branch
from
bfbef61
to
ed4f117
Compare
ppontes
changed the title
|
@ppontes the patches need update - you can also just curl & apply https://680101-9384267-gh.circle-artifacts.com/0/patches/update-patches.patch |
nornagon
approved these changes
Oct 9, 2020
zcbenz
approved these changes
Oct 13, 2020
ppontes
force-pushed
the
ppontes/cherry-pick/10-x-y/chromium/7e42e0a7c6-n-b1b3ccbd57
branch
from
29c5a9a
to
9640650
Compare
|
Release Notes Persisted
|
zcbenz
deleted the
ppontes/cherry-pick/10-x-y/chromium/7e42e0a7c6-n-b1b3ccbd57
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't create providers if context is lost
CanvasResourceProvider::CreateSharedImageProvider receives a weak pointer
to the ContextProviderWrapper and returns nullptr if it does not exist.
Unfortunately SharedGpuContext::IsGpuCompositingEnabled can re-create
the ContextProviderWrapper after this check happens, leading to potential
use-after-frees.
To me it simply makes the most sense to not create a CRP if context is
lost, as the created provider would be invalid and nullptr would get
returned anyway.
Bug: 1126424
Change-Id: Ic92709d7a38d94e5e7529efac3a09405d64eaa34
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2417097
Reviewed-by: Juanmi Huertas juanmihd@chromium.org
Reviewed-by: Fernando Serboncini fserb@chromium.org
Commit-Queue: Aaron Krajeski aaronhk@chromium.org
Cr-Commit-Position: refs/heads/master@{#809327}
Release Notes
Notes: Backported the fix to CVE-2020-15968: Use after free in Blink.