Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: improve app 'session-created' event spec #25799

Merged
merged 1 commit into from
Oct 7, 2020

Conversation

miniak
Copy link
Contributor

@miniak miniak commented Oct 6, 2020

Description of Change

Makes the test fail without #25798

not ok 1 session module session-created event is emitted when a session is created
  TypeError: Illegal invocation: Function must be called on an object of type Session
      at formatProperty (node_modules/chai/lib/chai/utils/inspect.js:294:31)
      at /Users/miburda/Development/github/electron-gn/src/electron/node_modules/chai/lib/chai/utils/inspect.js:190:14
      at Array.map (<anonymous>)
      at formatValue (node_modules/chai/lib/chai/utils/inspect.js:189:19)
      at inspect (node_modules/chai/lib/chai/utils/inspect.js:32:10)
      at objDisplay (node_modules/chai/lib/chai/utils/objDisplay.js:28:13)
      at /Users/miburda/Development/github/electron-gn/src/electron/node_modules/chai/lib/chai/utils/getMessage.js:47:48
      at String.replace (<anonymous>)
      at Object.getMessage (node_modules/chai/lib/chai/utils/getMessage.js:47:6)
      at Proxy.Assertion.assert (node_modules/chai/lib/chai/assertion.js:139:18)

Checklist

Release Notes

Notes: no-notes

@Azadmoradiazad13699

This comment has been minimized.

@alexeykuzmin alexeykuzmin merged commit 65089a6 into master Oct 7, 2020
@release-clerk
Copy link

release-clerk bot commented Oct 7, 2020

No Release Notes

@alexeykuzmin
Copy link
Contributor

The "electron-woa-testing" failure is not related.

@alexeykuzmin alexeykuzmin deleted the miniak/session-created-spec branch October 7, 2020 13:59
@trop
Copy link
Contributor

trop bot commented Oct 7, 2020

I was unable to backport this PR to "9-x-y" cleanly;
you will need to perform this backport manually.

@trop
Copy link
Contributor

trop bot commented Oct 7, 2020

I have automatically backported this PR to "11-x-y", please check out #25803

@trop
Copy link
Contributor

trop bot commented Oct 7, 2020

I have automatically backported this PR to "10-x-y", please check out #25804

@trop trop bot added the merged/9-x-y label Oct 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants