Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: add a wrapper for wrangling uv handles. #25663

Merged
merged 4 commits into from Sep 28, 2020
Merged

refactor: add a wrapper for wrangling uv handles. #25663

merged 4 commits into from Sep 28, 2020

Commits on Sep 28, 2020

  1. refactor: add a wrapper for wrangling uv handles. 

    Part 1 of a fix for #25248, #22069.

Place the uv_asyncs owned by NodeBindings, ElectronBindings inside a new
UvHandle wrapper class which manages uv_handles' need for their closed()
callback to be invoked before the handles' memory can be freed.
    @ckerr @electron-bot
    ckerr authored and electron-bot committed Sep 28, 2020
    Copy the full SHA
    b3d0150 View commit details
    Browse the repository at this point in the history

  2. chore: make lint happy

    @ckerr @electron-bot
    ckerr authored and electron-bot committed Sep 28, 2020
    Copy the full SHA
    5bff233 View commit details
    Browse the repository at this point in the history

  3. refactor: use DCHECK_EQ() instead of DCHECK()

    @ckerr @electron-bot
    ckerr authored and electron-bot committed Sep 28, 2020
    Copy the full SHA
    0ecf83d View commit details
    Browse the repository at this point in the history

  4. refactor: fix oops

    @ckerr @electron-bot
    ckerr authored and electron-bot committed Sep 28, 2020
    Copy the full SHA
    fa07f15 View commit details
    Browse the repository at this point in the history