chore: improve renderer crash logging #25592
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
nornagon
approved these changes
Sep 23, 2020
| @@ -462,8 +462,7 @@ const addReturnValueToEvent = (event: any) => { | |||
| }; | |||
|
|
|||
| const loggingEnabled = () => { | |||
| return Object.prototype.hasOwnProperty.call(process.env, 'ELECTRON_ENABLE_LOGGING') || | |||
| process.argv.some(arg => arg.toLowerCase().startsWith('--enable-logging')); | |||
| return process.env.ELECTRON_ENABLE_LOGGING || app.commandLine.hasSwitch('enable-logging'); | |||
There was a problem hiding this comment.
teeeeechnically the logic for this in base::Environment is different. Ideally we'd just query this info directly from the C++ which actually controls logging, rather than trying to reimplement this.
Things that enable logging in the C++ without tripping this test, for example:
ELECTRON_ENABLE_LOGGING=0
electron_enable_logging=1
# only on non-Windows platforms:
ELECTRON_ENABLE_LOGGING=
I don't think it's very important to match exactly, but JFYI.
codebytere
approved these changes
Sep 23, 2020
alexeykuzmin
approved these changes
Sep 24, 2020
|
No Release Notes |
This was referenced Sep 24, 2020
|
I have automatically backported this PR to "11-x-y", please check out #25619 |
|
I have automatically backported this PR to "9-x-y", please check out #25620 |
|
I have automatically backported this PR to "10-x-y", please check out #25621 |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Follow up to #25317
Checklist
npm testpassesRelease Notes
Notes: no-notes