Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: decompress devtools discovery html #25576

Merged
merged 1 commit into from Sep 23, 2020

Conversation

nornagon
Copy link
Member

Description of Change

Beginning with
https://chromium.googlesource.com/chromium/src/+/6b83ee683f6c545be29ee807c6d0b6ac1508a549,
rolled into Electron with #23219, grit compresses html/js/css/svg by default.
We were serving the raw resource for the devtools discovery page (shown when
using --remote-debugging-port=9092), which was serving a raw gzipped page. We
now use a more appropriate accessor which decompresses if needed.

Fixes #25570.

Checklist

Release Notes

Notes: Fixed the remote-debugging-port discovery page showing garbled text.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Sep 22, 2020
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Sep 23, 2020
@nornagon
Copy link
Member Author

CI failure unrelated; merging.

@nornagon nornagon merged commit 881ac99 into master Sep 23, 2020
@release-clerk
Copy link

release-clerk bot commented Sep 23, 2020

Release Notes Persisted

Fixed the remote-debugging-port discovery page showing garbled text.

@nornagon nornagon deleted the decompress-devtools-discovery-html branch September 23, 2020 18:47
@trop
Copy link
Contributor

trop bot commented Sep 23, 2020

I have automatically backported this PR to "10-x-y", please check out #25601

@trop
Copy link
Contributor

trop bot commented Sep 23, 2020

I have automatically backported this PR to "11-x-y", please check out #25602

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remote Debugger does not work
3 participants