fix: decompress devtools discovery html #25576
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Beginning with
https://chromium.googlesource.com/chromium/src/+/6b83ee683f6c545be29ee807c6d0b6ac1508a549,
rolled into Electron with #23219, grit compresses html/js/css/svg by default.
We were serving the raw resource for the devtools discovery page (shown when
using
--remote-debugging-port=9092
), which was serving a raw gzipped page. Wenow use a more appropriate accessor which decompresses if needed.
Fixes #25570.
Checklist
npm test
passesRelease Notes
Notes: Fixed the remote-debugging-port discovery page showing garbled text.