Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: prevent destroyed view references from causing crashes #25511

Merged
merged 15 commits into from Sep 24, 2020
Merged

fix: prevent destroyed view references from causing crashes #25511

merged 15 commits into from Sep 24, 2020

Commits on Sep 17, 2020

  1. fix: prevent destroyed view references from causing crashes

    @mlaurencin @electron-bot
    mlaurencin authored and electron-bot committed Sep 17, 2020
    Copy the full SHA
    0fa9116 View commit details
    Browse the repository at this point in the history

  2. Remove extraneous comments

    @mlaurencin @electron-bot
    mlaurencin authored and electron-bot committed Sep 17, 2020
    Copy the full SHA
    f533f7f View commit details
    Browse the repository at this point in the history

  3. Relocate crash test to proper location

    @mlaurencin @electron-bot
    mlaurencin authored and electron-bot committed Sep 17, 2020
    Copy the full SHA
    9989f8d View commit details
    Browse the repository at this point in the history

  4. Add WebContentsObserver

    @mlaurencin @electron-bot
    mlaurencin authored and electron-bot committed Sep 17, 2020
    Copy the full SHA
    cb5d8a3 View commit details
    Browse the repository at this point in the history

  5. Add nullptr check and inspectable observer

    @mlaurencin @electron-bot
    mlaurencin authored and electron-bot committed Sep 17, 2020
    Copy the full SHA
    09f8eac View commit details
    Browse the repository at this point in the history

  6. Remote initial test file

    @mlaurencin @electron-bot
    mlaurencin authored and electron-bot committed Sep 17, 2020
    Copy the full SHA
    163ca55 View commit details
    Browse the repository at this point in the history

  7. Add test cases to test file

    @mlaurencin @electron-bot
    mlaurencin authored and electron-bot committed Sep 17, 2020
    Copy the full SHA
    00ce25c View commit details
    Browse the repository at this point in the history

  8. Rename and move testing file

    @mlaurencin @electron-bot
    mlaurencin authored and electron-bot committed Sep 17, 2020
    Copy the full SHA
    a32ade6 View commit details
    Browse the repository at this point in the history

  9. Fix linting errors

    @mlaurencin @electron-bot
    mlaurencin authored and electron-bot committed Sep 17, 2020
    Copy the full SHA
    213d48b View commit details
    Browse the repository at this point in the history

  10. Make functions exit early on check

    @mlaurencin @electron-bot
    mlaurencin authored and electron-bot committed Sep 17, 2020
    Copy the full SHA
    1d73205 View commit details
    Browse the repository at this point in the history

  11. Fix setBackgroundColor function call in test file

    @mlaurencin @electron-bot
    mlaurencin authored and electron-bot committed Sep 17, 2020
    Copy the full SHA
    20e2ca3 View commit details
    Browse the repository at this point in the history

  12. Fix styling of test file

    @mlaurencin @electron-bot
    mlaurencin authored and electron-bot committed Sep 17, 2020
    Copy the full SHA
    05bc606 View commit details
    Browse the repository at this point in the history

  13. Fix mac name mismatch and make variable name more clear

    @mlaurencin @electron-bot
    mlaurencin authored and electron-bot committed Sep 17, 2020
    Copy the full SHA
    755e382 View commit details
    Browse the repository at this point in the history

Commits on Sep 23, 2020

  1. Address extra null checks & update test 

    Co-authored-by: Michaela Laurencin <laurencinmg@gmail.com>
    @codebytere @mlaurencin
    codebytere and mlaurencin committed Sep 23, 2020
    Copy the full SHA
    867cfe2 View commit details
    Browse the repository at this point in the history

Commits on Sep 24, 2020

  1. fix: prevent destroyed view references from causing crashes

    @codebytere
    codebytere committed Sep 24, 2020
    Copy the full SHA
    6b2dbfd View commit details
    Browse the repository at this point in the history