Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: prevent destroyed view references from causing crashes #25510

Closed
wants to merge 13 commits into from
Closed

fix: prevent destroyed view references from causing crashes #25510

wants to merge 13 commits into from

Commits on Sep 17, 2020

  1. fix: prevent destroyed view references from causing crashes

    @mlaurencin @electron-bot
    mlaurencin authored and electron-bot committed Sep 17, 2020
    Configuration menu
    Copy the full SHA
    cea931d View commit details
    Browse the repository at this point in the history

  2. Remove extraneous comments

    @mlaurencin @electron-bot
    mlaurencin authored and electron-bot committed Sep 17, 2020
    Configuration menu
    Copy the full SHA
    5f90d9e View commit details
    Browse the repository at this point in the history

  3. Relocate crash test to proper location

    @mlaurencin @electron-bot
    mlaurencin authored and electron-bot committed Sep 17, 2020
    Configuration menu
    Copy the full SHA
    23c2784 View commit details
    Browse the repository at this point in the history

  4. Add WebContentsObserver

    @mlaurencin @electron-bot
    mlaurencin authored and electron-bot committed Sep 17, 2020
    Configuration menu
    Copy the full SHA
    5e0c609 View commit details
    Browse the repository at this point in the history

  5. Add nullptr check and inspectable observer

    @mlaurencin @electron-bot
    mlaurencin authored and electron-bot committed Sep 17, 2020
    Configuration menu
    Copy the full SHA
    1e0c5c1 View commit details
    Browse the repository at this point in the history

  6. Remote initial test file

    @mlaurencin @electron-bot
    mlaurencin authored and electron-bot committed Sep 17, 2020
    Configuration menu
    Copy the full SHA
    8141c68 View commit details
    Browse the repository at this point in the history

  7. Add test cases to test file

    @mlaurencin @electron-bot
    mlaurencin authored and electron-bot committed Sep 17, 2020
    Configuration menu
    Copy the full SHA
    cd363ef View commit details
    Browse the repository at this point in the history

  8. Rename and move testing file

    @mlaurencin @electron-bot
    mlaurencin authored and electron-bot committed Sep 17, 2020
    Configuration menu
    Copy the full SHA
    ecf289f View commit details
    Browse the repository at this point in the history

  9. Fix linting errors

    @mlaurencin @electron-bot
    mlaurencin authored and electron-bot committed Sep 17, 2020
    Configuration menu
    Copy the full SHA
    535bfef View commit details
    Browse the repository at this point in the history

  10. Make functions exit early on check

    @mlaurencin @electron-bot
    mlaurencin authored and electron-bot committed Sep 17, 2020
    Configuration menu
    Copy the full SHA
    b06d9d8 View commit details
    Browse the repository at this point in the history

  11. Fix setBackgroundColor function call in test file

    @mlaurencin @electron-bot
    mlaurencin authored and electron-bot committed Sep 17, 2020
    Configuration menu
    Copy the full SHA
    b9d035c View commit details
    Browse the repository at this point in the history

  12. Fix styling of test file

    @mlaurencin @electron-bot
    mlaurencin authored and electron-bot committed Sep 17, 2020
    Configuration menu
    Copy the full SHA
    35803c7 View commit details
    Browse the repository at this point in the history

  13. Fix mac name mismatch and make variable name more clear

    @mlaurencin @electron-bot
    mlaurencin authored and electron-bot committed Sep 17, 2020
    Configuration menu
    Copy the full SHA
    1c52f72 View commit details
    Browse the repository at this point in the history