Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: call node::Stop on exit #25459

Merged
merged 3 commits into from Sep 16, 2020
Merged

fix: call node::Stop on exit #25459

merged 3 commits into from Sep 16, 2020

Commits on Sep 14, 2020

  1. fix: call node::Stop on exit

    @nornagon @electron-bot
    nornagon authored and electron-bot committed Sep 14, 2020
    Copy the full SHA
    dd6e670 View commit details
    Browse the repository at this point in the history

  2. also call Stop in node_main

    @nornagon @electron-bot
    nornagon authored and electron-bot committed Sep 14, 2020
    Copy the full SHA
    d26ecd8 View commit details
    Browse the repository at this point in the history

  3. oop, we were already calling set_can_call_into_js(false)??

    @nornagon @electron-bot
    nornagon authored and electron-bot committed Sep 14, 2020
    Copy the full SHA
    f0b7ff1 View commit details
    Browse the repository at this point in the history