Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: prevent destroyed view references from causing crashes #25411

Merged
merged 13 commits into from Sep 17, 2020
Merged

fix: prevent destroyed view references from causing crashes #25411

merged 13 commits into from Sep 17, 2020

Commits on Sep 16, 2020

  1. [WIP] fix: prevent destroyed view references from causing crashes

    @mlaurencin
    mlaurencin committed Sep 16, 2020
    Configuration menu
    Copy the full SHA
    4c860f6 View commit details
    Browse the repository at this point in the history

  2. Remove extraneous comments

    @mlaurencin
    mlaurencin committed Sep 16, 2020
    Configuration menu
    Copy the full SHA
    2533551 View commit details
    Browse the repository at this point in the history

  3. Relocate crash test to proper location

    @mlaurencin
    mlaurencin committed Sep 16, 2020
    Configuration menu
    Copy the full SHA
    b77f186 View commit details
    Browse the repository at this point in the history

  4. Add WebContentsObserver

    @mlaurencin
    mlaurencin committed Sep 16, 2020
    Configuration menu
    Copy the full SHA
    39ed4e6 View commit details
    Browse the repository at this point in the history

  5. Add nullptr check and inspectable observer

    @mlaurencin
    mlaurencin committed Sep 16, 2020
    Configuration menu
    Copy the full SHA
    c41606d View commit details
    Browse the repository at this point in the history

  6. Remote initial test file

    @mlaurencin
    mlaurencin committed Sep 16, 2020
    Configuration menu
    Copy the full SHA
    4801298 View commit details
    Browse the repository at this point in the history

  7. Add test cases to test file

    @mlaurencin
    mlaurencin committed Sep 16, 2020
    Configuration menu
    Copy the full SHA
    5137bb8 View commit details
    Browse the repository at this point in the history

  8. Rename and move testing file

    @mlaurencin
    mlaurencin committed Sep 16, 2020
    Configuration menu
    Copy the full SHA
    29ce39f View commit details
    Browse the repository at this point in the history

  9. Fix linting errors

    @mlaurencin
    mlaurencin committed Sep 16, 2020
    Configuration menu
    Copy the full SHA
    0e4a1f7 View commit details
    Browse the repository at this point in the history

  10. Make functions exit early on check

    @mlaurencin
    mlaurencin committed Sep 16, 2020
    Configuration menu
    Copy the full SHA
    2b0953f View commit details
    Browse the repository at this point in the history

  11. Fix setBackgroundColor function call in test file

    @mlaurencin
    mlaurencin committed Sep 16, 2020
    Configuration menu
    Copy the full SHA
    e0da5b2 View commit details
    Browse the repository at this point in the history

  12. Fix styling of test file

    @mlaurencin
    mlaurencin committed Sep 16, 2020
    Configuration menu
    Copy the full SHA
    ae365b3 View commit details
    Browse the repository at this point in the history

  13. Fix mac name mismatch and make variable name more clear

    @mlaurencin
    mlaurencin committed Sep 16, 2020
    Configuration menu
    Copy the full SHA
    5128cb0 View commit details
    Browse the repository at this point in the history