Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: clean up leaked v8 objects in net.request #25382

Merged
merged 1 commit into from
Sep 10, 2020
Merged

fix: clean up leaked v8 objects in net.request #25382

merged 1 commit into from
Sep 10, 2020

Conversation

nornagon
Copy link
Member

@nornagon nornagon commented Sep 8, 2020

Description of Change

Fixes #25365.

This backports a portion of #22531.

Checklist

Release Notes

Notes: Fixed a memory leak in net.request().

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Sep 8, 2020
@nornagon nornagon changed the title fix: memory leak in net.request fix: clean up leaked v8 objects in net.request Sep 8, 2020
@nornagon nornagon added the backport-check-skip Skip trop's backport validity checking label Sep 8, 2020
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Sep 9, 2020
@zcbenz zcbenz merged commit 75f193a into 9-x-y Sep 10, 2020
@release-clerk
Copy link

release-clerk bot commented Sep 10, 2020

Release Notes Persisted

Fixed a memory leak in net.request().

@zcbenz zcbenz deleted the nornagon-patch-1 branch September 10, 2020 02:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zcbenz zcbenz zcbenz approved these changes

@MarshallOfSound MarshallOfSound MarshallOfSound approved these changes

Assignees
No one assigned
Labels
backport-check-skip Skip trop's backport validity checking
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nornagon @zcbenz @MarshallOfSound