fix(extensions): define platform info to prevent renderer crash

[samuelmaddock]

Description of Change

Fully implements chrome.runtime.getPlatformInfo such that the calling renderer won't crash/hang.

The implementation is copied from chrome/browser/extensions/api/runtime/chrome_runtime_api_delegate.cc.

Ref #19447

cc @nornagon @sentialx

Checklist

• PR description included and stakeholders cc'd
• npm test passes
• tests are changed or added
• relevant documentation is changed or added
• PR title follows semantic commit guidelines
• PR release notes describe the change in a way relevant to app developers, and are capitalized, punctuated, and past tense.

Release Notes

Notes: Fixed chrome.runtime.getPlatformInfo crashing the background process upon being invoked.

[sentialx]

LGTM

[nornagon]

Looks like you're missing a dependency declaration in the BUILD.gn file:

ERROR at //electron/shell/browser/extensions/api/runtime/electron_runtime_api_delegate.cc:10:11: Can't include this header from here.
#include "components/update_client/update_query_params.h"
          ^---------------------------------------------
The target:
  //electron:electron_lib
is including a file from the target:
  //components/update_client:update_client

While it's a little questionable for us to be making a dependency on something called "update client" (given we don't use any of the actual functionality of that component), we're already transitively dependent on it via //extensions/browser, so adding it as an explicit dependency seems OK.

[nornagon]

Also, I'm surprised this crashed before. Can you provide some more info about the crash this fixes?

[samuelmaddock]

Also, I'm surprised this crashed before. Can you provide some more info about the crash this fixes?

@nornagon what seems to happen is the API attempts to use PlatformInfo in a response, but doesn't handle it well when some of the fields aren't initialized. Specifically the call to runtime::GetPlatformInfo::Results::Create(info). Then runtime::ToString is called on uninitialized data in a PlatformInfo generated function.

[gittysachin]

So far, LGTM

[release-clerk]

Release Notes Persisted

Fixed chrome.runtime.getPlatformInfo crashing the background process upon being invoked.