Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update node certdata to NSS 3.56 #25313

Merged
merged 1 commit into from Sep 8, 2020
Merged

fix: update node certdata to NSS 3.56 #25313

merged 1 commit into from Sep 8, 2020

Conversation

nornagon
Copy link
Member

@nornagon nornagon commented Sep 3, 2020

Description of Change

Fixes #24123

It's unclear to me why #24266 didn't fix that issue, but this seems to. Node hasn't shipped this version of NSS yet. I believe https://phabricator.services.mozilla.com/D79374 is the revision that removes the expired certs in NSS.

Checklist

Release Notes

Notes: Updated Node root certs to use NSS 3.56.

@nornagon nornagon requested a review from a team as a code owner September 3, 2020 20:39
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Sep 3, 2020
@deepak1556
Copy link
Member

It's unclear to me why #24266 didn't fix that issue, but this seems to

Looks like it, based on the PR link it has milestone of 3.54 https://bugzilla.mozilla.org/show_bug.cgi?id=1645199, not sure why node chose 3.53 😕

Should node_root_certs.h also be updated here following https://github.com/nodejs/node/blob/master/doc/guides/maintaining-root-certs.md ?

@deepak1556
Copy link
Member

Should node_root_certs.h also be updated here following

Ah missed that you did it in the same commit.

@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Sep 4, 2020
@zcbenz zcbenz merged commit 2c5c51a into master Sep 8, 2020
@release-clerk
Copy link

release-clerk bot commented Sep 8, 2020

Release Notes Persisted

Updated Node root certs to use NSS 3.56.

@trop
Copy link
Contributor

trop bot commented Sep 8, 2020

I have automatically backported this PR to "10-x-y", please check out #25361

@trop
Copy link
Contributor

trop bot commented Sep 8, 2020

I have automatically backported this PR to "11-x-y", please check out #25362

@trop
Copy link
Contributor

trop bot commented Sep 8, 2020

I have automatically backported this PR to "8-x-y", please check out #25363

@trop trop bot removed the target/11-x-y label Sep 8, 2020
@trop
Copy link
Contributor

trop bot commented Sep 8, 2020

I have automatically backported this PR to "9-x-y", please check out #25364

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AddTrust CA root cert expiration breaking TLS connections through Node
4 participants