Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: graceful handling of notes with sub-lists #25279

Merged
merged 5 commits into from Sep 3, 2020
Merged

chore: graceful handling of notes with sub-lists #25279

merged 5 commits into from Sep 3, 2020

Conversation

ckerr
Copy link
Member

@ckerr ckerr commented Sep 2, 2020 •
edited

Description of Change

Handle multine release notes that contain their own bullet points.

Also, if a release note begins with a bullet point, remove it because it will confuse the markdown parser to have two bullet points.

Before and After:

    • Fixes the following issues for frameless when maximized on Windows: * fix unreachable task bar when auto hidden with position top * fix 1px extending to secondary monitor * fix 1px overflowing into taskbar at certain resolutions * fix white line on top of window under 4k resolutions. #25216 (Also in 8, 9, 11)
  • Fixed the following issues for frameless when maximized on Windows:
    • fix unreachable task bar when auto hidden with position top
    • fix 1px extending to secondary monitor
    • fix 1px overflowing into taskbar at certain resolutions
    • fix white line on top of window under 4k resolutions. #25216 (Also in 8, 9, 11)

CC @codebytere @MarshallOfSound

Checklist

Release Notes

Notes: none

@ckerr
chore: graceful handling of notes with sub-lists
3edac15 
Handle multine release notes that contain their own bullet points.

Also, if a release note begins with a bullet point, remove it because it
will confuse the markdown parser to have two bullet points.
@ckerr ckerr requested a review from a team as a code owner September 2, 2020 16:33
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Sep 2, 2020
codebytere
codebytere reviewed Sep 2, 2020
View reviewed changes
Copy link
Member

@codebytere codebytere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ckerr do you have a before and after example of formatting with bullet points?
I'd also prefer we add some tests if possible! (lint is dying too)

@ckerr
Copy link
Member Author

ckerr commented Sep 2, 2020

@ckerr do you have a before and after example of formatting with bullet points?

@codebytere added in description

I'd also prefer we add some tests if possible!

Added 3badf00

(lint is dying too)

Fixed bd296fe

codebytere
codebytere approved these changes Sep 2, 2020
View reviewed changes
Copy link
Member

@codebytere codebytere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

ckerr added a commit that referenced this pull request Sep 3, 2020
@ckerr
chore: sync 10-x-y release notes script to master
87e3181 
* adds the '(Also in N-x-y)' annotations
* handle sublists in release notes (#25279)
* has prepare-release.js catch thrown exceptions (#24923)
* syncs related tests
@ckerr ckerr mentioned this pull request Sep 3, 2020
Merged
5 tasks
@trop
Copy link
Contributor

trop bot commented Sep 3, 2020

@ckerr has manually backported this PR to "10-x-y", please check out #25304

@trop trop bot added the in-flight/10-x-y label Sep 3, 2020
ckerr added a commit that referenced this pull request Sep 3, 2020
@ckerr
chore: sync 9-x-y release notes script to master
7e72da5 
* adds the '(Also in N-x-y)' annotations
* handle sublists in release notes (#25279)
* has prepare-release.js catch thrown exceptions (#24923)
* syncs related tests
@ckerr ckerr mentioned this pull request Sep 3, 2020
Merged
5 tasks
@trop
Copy link
Contributor

trop bot commented Sep 3, 2020

@ckerr has manually backported this PR to "9-x-y", please check out #25305

@trop trop bot added the in-flight/9-x-y label Sep 3, 2020
ckerr added a commit that referenced this pull request Sep 3, 2020
@ckerr
chore: sync 8-x-y release notes script to master
2db1f2f 
* adds the '(Also in N-x-y)' annotations
* handle sublists in release notes (#25279)
* has prepare-release.js catch thrown exceptions (#24923)
* syncs related tests
@ckerr ckerr mentioned this pull request Sep 3, 2020
Merged
5 tasks
@trop
Copy link
Contributor

trop bot commented Sep 3, 2020

@ckerr has manually backported this PR to "8-x-y", please check out #25306

@trop trop bot added the in-flight/8-x-y label Sep 3, 2020
@ckerr
chore: add commits to release-notes test cache
a38c3da 
No behavior change; just includes files that ought to be cached to prevent
hitting octokit for them.
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Sep 3, 2020
@ckerr ckerr merged commit 4484e95 into master Sep 3, 2020
@ckerr ckerr deleted the ckerr/master/multiline-release-notes branch September 3, 2020 19:42
@release-clerk
Copy link

release-clerk bot commented Sep 3, 2020

No Release Notes

@trop trop bot mentioned this pull request Sep 3, 2020
Merged
@trop
Copy link
Contributor

trop bot commented Sep 3, 2020

I have automatically backported this PR to "11-x-y", please check out #25312

zcbenz pushed a commit that referenced this pull request Sep 8, 2020
@ckerr
chore: sync 8-x-y release notes script to master (#25306)
32c7b35 
* adds the '(Also in N-x-y)' annotations
* handle sublists in release notes (#25279)
* has prepare-release.js catch thrown exceptions (#24923)
* syncs related tests
zcbenz pushed a commit that referenced this pull request Sep 8, 2020
@ckerr
chore: sync 9-x-y release notes script to master (#25305)
a90397f 
* adds the '(Also in N-x-y)' annotations
* handle sublists in release notes (#25279)
* has prepare-release.js catch thrown exceptions (#24923)
* syncs related tests
zcbenz pushed a commit that referenced this pull request Sep 8, 2020
@ckerr
chore: sync 10-x-y release notes script to master (#25304)
c6eeff8 
* chore: sync 10-x-y release notes script to master

* adds the '(Also in N-x-y)' annotations
* handle sublists in release notes (#25279)
* has prepare-release.js catch thrown exceptions (#24923)
* syncs related tests

* chore: update cache entries in release notes tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codebytere codebytere codebytere approved these changes

@MarshallOfSound MarshallOfSound MarshallOfSound approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ckerr @codebytere @MarshallOfSound