New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: do not reset process_id in URLLoaderFactoryParams #25139
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice find!
maybe reword to highlight same session since the comparison was done based on browser_context.
|
Release Notes Persisted
|
I have automatically backported this PR to "10-x-y", please check out #25178 |
I was unable to backport this PR to "8-x-y" cleanly; |
I have automatically backported this PR to "9-x-y", please check out #25179 |
I have automatically backported this PR to "11-x-y", please check out #25180 |
Description of Change
Fix #24991.
In
OverrideURLLoaderFactoryParams
when disabling CORB, theprocess_id
parameter was also changed.This would cause a DCHECK assertion under certain cases (see #24991 (comment)), and under Release build while the DHCECK assertion would be disabled, it would cause weird permission errors due to wrong process id being set (see #24991 (comment)).
This behavior was introduced by 6d3e6ab from #19488, according to its description, the purpose was to disable CORB when web security is disabled. The original change did need to set the
process_id
because it was constructing a new Param struct, but after later Chromium upgrades there was no longer need to setprocess_id
because the method was changed to override the parameters instead of creating a new one.Checklist
npm test
passesRelease Notes
Notes: Fix network permission error when there are multiple WebContents sharing same session are created with web security disabled.