New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(extensions): add support for some chrome.management APIs #25098
Conversation
Release Notes Persisted
|
@zcbenz Could it be backported to 9-x-y? |
/trop run backport |
The backport process for this PR has been manually initiated, here we go! :D |
I was unable to backport this PR to "10-x-y" cleanly; |
I was unable to backport this PR to "11-x-y" cleanly; |
@sentialx You have to manually backport the PR to 11/10/9 branches, and it would also require approval from @electron/wg-api to get merged. |
…on#25098) * fix: initialize management policy * fix(extensions): crash when using chrome.management * test: add tests * docs: add a note about chrome.management * fix: lint errors * fix: lint errors * fix: remove favicon_service include * fix: add missing management permission * docs: more supported apis * fix: extensions.md line endings
…on#25098) * fix: initialize management policy * fix(extensions): crash when using chrome.management * test: add tests * docs: add a note about chrome.management * fix: lint errors * fix: lint errors * fix: remove favicon_service include * fix: add missing management permission * docs: more supported apis * fix: extensions.md line endings
…on#25098) * fix: initialize management policy * fix(extensions): crash when using chrome.management * test: add tests * docs: add a note about chrome.management * fix: lint errors * fix: lint errors * fix: remove favicon_service include * fix: add missing management permission * docs: more supported apis * fix: extensions.md line endings
…on#25098) * fix: initialize management policy * fix(extensions): crash when using chrome.management * test: add tests * docs: add a note about chrome.management * fix: lint errors * fix: lint errors * fix: remove favicon_service include * fix: add missing management permission * docs: more supported apis * fix: extensions.md line endings
#25342) * fix: initialize management policy * fix(extensions): crash when using chrome.management * test: add tests * docs: add a note about chrome.management * fix: lint errors * fix: lint errors * fix: remove favicon_service include * fix: add missing management permission * docs: more supported apis * fix: extensions.md line endings
#25345) * fix: initialize management policy * fix(extensions): crash when using chrome.management * test: add tests * docs: add a note about chrome.management * fix: lint errors * fix: lint errors * fix: remove favicon_service include * fix: add missing management permission * docs: more supported apis * fix: extensions.md line endings
* feat(extensions): add support for some chrome.management APIs (#25098) * fix: initialize management policy * fix(extensions): crash when using chrome.management * test: add tests * docs: add a note about chrome.management * fix: lint errors * fix: lint errors * fix: remove favicon_service include * fix: add missing management permission * docs: more supported apis * fix: extensions.md line endings * feat(extensions): add support for some chrome.management APIs (#25098) * fix: initialize management policy * fix(extensions): crash when using chrome.management * test: add tests * docs: add a note about chrome.management * fix: lint errors * fix: lint errors * fix: remove favicon_service include * fix: add missing management permission * docs: more supported apis * fix: extensions.md line endings * Update electron_extensions_api_client.cc
Description of Change
This PR implements missing
extensions::ManagementAPIDelegate
which is being used bychrome.management
API and also fixes a crash when an extension is attempting to use the API.It doesn't implement all of the
chrome.management
functionalities, as they need to emit relevant events insession
or insession.extensions
, so that developers could set their own behavior. I will probably do that in another PR.Could this be backported to 9-x-y?
Checklist
npm test
passesRelease Notes
Notes: Added support for some
chrome.management
APIs.