Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: enable TLS renegotiation in node #25022

Merged
merged 1 commit into from Aug 19, 2020
Merged

fix: enable TLS renegotiation in node #25022

merged 1 commit into from Aug 19, 2020

Conversation

nornagon
Copy link
Member

@nornagon nornagon commented Aug 18, 2020 •
edited by codebytere

Description of Change

Closes #18380.

cc @numaanashraf

Checklist

Release Notes

Notes: Fixed node's TLS stack not allowing renegotiation.

@nornagon nornagon requested a review from a team as a code owner August 18, 2020 16:56
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Aug 18, 2020
@nornagon
Copy link
Member Author

Upstreaming here: nodejs/node#34832

@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Aug 19, 2020
@codebytere codebytere merged commit 9021843 into master Aug 19, 2020
@release-clerk
Copy link

release-clerk bot commented Aug 19, 2020

Release Notes Persisted

Fixed node's TLS stack not allowing renegotiation.

This was referenced Aug 19, 2020
Merged
Merged
Merged
@trop
Copy link
Contributor

trop bot commented Aug 19, 2020

I have automatically backported this PR to "10-x-y", please check out #25040

@trop
Copy link
Contributor

trop bot commented Aug 19, 2020

I have automatically backported this PR to "9-x-y", please check out #25041

@trop
Copy link
Contributor

trop bot commented Aug 19, 2020

I have automatically backported this PR to "8-x-y", please check out #25042

@nornagon nornagon deleted the node-tls-renego branch August 19, 2020 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zcbenz zcbenz zcbenz approved these changes

@codebytere codebytere codebytere approved these changes

@MarshallOfSound MarshallOfSound MarshallOfSound approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Node http request to API Server fails with TLS Error - No Renegotiation
4 participants
@nornagon @zcbenz @codebytere @MarshallOfSound