fix: do not render inactive titlebar as active on Windows #24847
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deepak1556
reviewed
Aug 5, 2020
| // active, which is different from most other win32 apps. We prevent this | ||
| // behavior by overriding the WM_NCACTIVATE message to default behavior. | ||
| // See also https://github.com/electron/electron/issues/24647. | ||
| *result = |
There was a problem hiding this comment.
Can't we instead override HWNDMessageHandlerDelegate::ShouldPaintAsActive() to false which would still resort to the default behavior because of paint_as_active || active ?
There was a problem hiding this comment.
This is a good idea 👍 , I have update the PR.
zcbenz
force-pushed
the
fix-active-titlebar
branch
from
6033754
to
89f9d74
Compare
deepak1556
approved these changes
Aug 6, 2020
codebytere
approved these changes
Aug 6, 2020
|
Failures are previously known and unrelated - merging. |
|
Release Notes Persisted
|
This was referenced Aug 6, 2020
|
I have automatically backported this PR to "9-x-y", please check out #24873 |
|
I have automatically backported this PR to "10-x-y", please check out #24874 |
|
I have automatically backported this PR to "8-x-y", please check out #24875 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Chromium renders titlebar as active as long as there is any views window active, even when current window is not active, which is different from most other win32 apps. We prevent this behavior by overriding the
WM_NCACTIVATEmessage to default behavior.Close #24647.
Checklist
npm testpassesRelease Notes
Notes: Fix inactive windows having active titlebar on Windows