Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(extensions): enable WebSQL in background pages #24798

Merged
merged 5 commits into from Aug 19, 2020
Merged

fix(extensions): enable WebSQL in background pages #24798

merged 5 commits into from Aug 19, 2020

Conversation

sentialx
Copy link
Contributor

@sentialx sentialx commented Jul 30, 2020 •
edited

Description of Change

Ref #19447

Fixes a security error when calling openDatabase in an extension background page. An example major extension which uses it is LastPass.

Could this be backported to 9-x-y?

cc @nornagon

Checklist

Release Notes

Notes: Fixed not working WebSQLDatabase in extension background pages.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Jul 30, 2020
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Jul 31, 2020
zcbenz
zcbenz approved these changes Aug 18, 2020
View reviewed changes
spec-main/extensions-spec.ts Outdated Show resolved Hide resolved
@zcbenz zcbenz merged commit 9e53112 into electron:master Aug 19, 2020
@release-clerk
Copy link

release-clerk bot commented Aug 19, 2020

Release Notes Persisted

Fixed not working WebSQLDatabase in extension background pages.

@trop
Copy link
Contributor

trop bot commented Aug 19, 2020

I was unable to backport this PR to "10-x-y" cleanly;
you will need to perform this backport manually.

@trop
Copy link
Contributor

trop bot commented Aug 19, 2020

I was unable to backport this PR to "9-x-y" cleanly;
you will need to perform this backport manually.

@codebytere
Copy link
Member

@sentialx could you please backport this to 10 and 9?

@sentialx sentialx mentioned this pull request Aug 20, 2020
Merged
6 tasks
@trop
Copy link
Contributor

trop bot commented Aug 20, 2020

@sentialx has manually backported this PR to "9-x-y", please check out #25070

@sentialx
Copy link
Contributor Author

@codebytere Sure

sentialx added a commit to sentialx/electron that referenced this pull request Aug 20, 2020
@sentialx
fix(extensions): enable WebSQL in background pages (electron#24798)
070d88d 
* fix(extensions): enable WebSQL in background pages

* fix: apply suggestions

* fix: remove duplicate include

* fix: remove trailing spaces
@sentialx sentialx mentioned this pull request Aug 20, 2020
Merged
6 tasks
@trop
Copy link
Contributor

trop bot commented Aug 20, 2020

@sentialx has manually backported this PR to "10-x-y", please check out #25071

@sentialx sentialx mentioned this pull request Feb 14, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nornagon nornagon nornagon left review comments

@zcbenz zcbenz zcbenz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@sentialx @codebytere @nornagon @zcbenz