Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(extensions): bypass cors in requests made from background pages #24483

Merged
merged 5 commits into from Aug 3, 2020
Merged

fix(extensions): bypass cors in requests made from background pages #24483

merged 5 commits into from Aug 3, 2020

Conversation

sentialx
Copy link
Contributor

@sentialx sentialx commented Jul 9, 2020 •
edited

Description of Change

This PR fixes CORS issues mentioned in #19447 (comment).
Could this be backported to 9-x-y, please?

cc @nornagon

Checklist

Release Notes

Notes: Fixed issues with CORS when making requests from extensions.

@electron-cation electron-cation bot added new-pr 🌱 PR opened in the last 24 hours and removed new-pr 🌱 PR opened in the last 24 hours labels Jul 9, 2020
@codebytere
Copy link
Member

@sentialx would it be possible to add a test for this?

@codebytere codebytere requested a review from nornagon July 16, 2020 03:48
@sentialx
Copy link
Contributor Author

@codebytere Are the tests okay?

codebytere
codebytere approved these changes Jul 28, 2020
View reviewed changes
Copy link
Member

@codebytere codebytere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

nornagon
nornagon requested changes Jul 29, 2020
View reviewed changes
Copy link
Member

@nornagon nornagon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like the tests are failing after i fixed them.

@sentialx sentialx requested review from a team as code owners July 30, 2020 12:07
@sentialx
Copy link
Contributor Author

Oh no, I forgot to add <all_urls> to permissions.

@nornagon nornagon merged commit f53aac9 into electron:master Aug 3, 2020
@release-clerk
Copy link

release-clerk bot commented Aug 3, 2020

Release Notes Persisted

Fixed issues with CORS when making requests from extensions.

@trop
Copy link
Contributor

trop bot commented Aug 3, 2020

I was unable to backport this PR to "9-x-y" cleanly;
you will need to perform this backport manually.

@trop trop bot mentioned this pull request Aug 3, 2020
Merged
@trop
Copy link
Contributor

trop bot commented Aug 3, 2020

I have automatically backported this PR to "10-x-y", please check out #24822

@sentialx sentialx mentioned this pull request Aug 10, 2020
Merged
6 tasks
@trop
Copy link
Contributor

trop bot commented Aug 10, 2020

@sentialx has manually backported this PR to "9-x-y", please check out #24915

@khwaaj khwaaj mentioned this pull request Aug 21, 2020
Closed
@sentialx sentialx mentioned this pull request Feb 14, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nornagon nornagon nornagon approved these changes

@codebytere codebytere codebytere approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sentialx @codebytere @nornagon