Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: intermittent 100% CPU usage on macOS #24394

Merged
merged 1 commit into from Jul 3, 2020
Merged

fix: intermittent 100% CPU usage on macOS #24394

merged 1 commit into from Jul 3, 2020

Conversation

codebytere
Copy link
Member

@codebytere codebytere commented Jul 2, 2020 •
edited

Description of Change

Closes #24385.

Fixes an issue caused by libuv/libuv#2891:

The problem is that CLOCK_UPTIME_RAW experiences an epoch reset (ie it goes backwards) sometimes when the machine has been asleep. In my testing it seems that a sleep of over 1 hour with under 50% battery remaining triggers this effect reasonably reliably - I guess that this combination makes the machine enter a very-low-power state that resets whatever counter is used.

cc @WillerZ @zcbenz @nornagon @deepak1556

Checklist

Release Notes

Notes: Fixes an intermittent high-CPU usage problem caused a system clock issue during sleep.

@codebytere codebytere requested a review from a team as a code owner July 2, 2020 05:12
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Jul 2, 2020
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Jul 3, 2020
@codebytere codebytere merged commit 9106d0c into master Jul 3, 2020
@release-clerk
Copy link

release-clerk bot commented Jul 3, 2020

Release Notes Persisted

Fixes an intermittent high-CPU usage problem caused a system clock issue during sleep.

@codebytere codebytere deleted the fix-cpu-issue branch July 3, 2020 16:18
This was referenced Jul 3, 2020
Merged
Merged
Merged
@trop
Copy link
Contributor

trop bot commented Jul 3, 2020

I have automatically backported this PR to "10-x-y", please check out #24413

@trop trop bot removed the target/10-x-y label Jul 3, 2020
@trop
Copy link
Contributor

trop bot commented Jul 3, 2020

I have automatically backported this PR to "8-x-y", please check out #24414

@trop trop bot added the in-flight/10-x-y label Jul 3, 2020
@trop
Copy link
Contributor

trop bot commented Jul 3, 2020

I have automatically backported this PR to "9-x-y", please check out #24415

sentialx pushed a commit to sentialx/electron that referenced this pull request Jul 30, 2020
@codebytere @sentialx
fix: intermittent 100% CPU usage on macOS (electron#24394)
833ec04
sentialx pushed a commit to sentialx/electron that referenced this pull request Apr 8, 2021
@codebytere @sentialx
fix: intermittent 100% CPU usage on macOS (electron#24394)
494c1f6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zcbenz zcbenz zcbenz approved these changes

@deepak1556 deepak1556 deepak1556 approved these changes

@miniak miniak miniak approved these changes

@nornagon nornagon Awaiting requested review from nornagon

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Intermittent 100% CPU usage on macos
4 participants
@codebytere @zcbenz @deepak1556 @miniak