fix: macOS modal focus behavior #24286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codebytere
force-pushed
the
modal-focus-fix
branch
from
b0ff94a
to
6f28ad2
Compare
codebytere
force-pushed
the
modal-focus-fix
branch
from
6f28ad2
to
5830d73
Compare
zcbenz
approved these changes
Jun 25, 2020
|
Release Notes Persisted
|
This was referenced Jun 29, 2020
|
I have automatically backported this PR to "10-x-y", please check out #24352 |
|
I have automatically backported this PR to "8-x-y", please check out #24353 |
|
I have automatically backported this PR to "9-x-y", please check out #24354 |
sentialx
pushed a commit
to sentialx/electron
that referenced
this pull request
Jul 30, 2020
sentialx
pushed a commit
to sentialx/electron
that referenced
this pull request
Apr 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Closes #18502.
Refs #19128 (comment).
Splits out
SetActivebehavior fromOnWindowFocus/OnWindowBlurinto a new methodOnWindowIsKeyChanged.Tested with https://gist.github.com/86396ae26e6462de78dbb9abf38402fd and confirmed not to regress #19124.
Before:
After:
cc @zcbenz @MarshallOfSound @deepak1556 @erickzhao
Checklist
npm testpassesRelease Notes
Notes: Fixed bug on macOS where the main window could be targeted for a focus event when it was disabled behind a modal.