Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support suspend/resume on Windows #24251

Merged
merged 1 commit into from Jun 24, 2020
Merged

feat: support suspend/resume on Windows #24251

merged 1 commit into from Jun 24, 2020

Conversation

codebytere
Copy link
Member

@codebytere codebytere commented Jun 23, 2020 •
edited

Description of Change

Closes #24244.

Add support for suspend and resume on Windows.

cc @zcbenz @MarshallOfSound @deepak1556

Checklist

Release Notes

Notes: Added support for suspend and resume events to Windows.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Jun 23, 2020
@deepak1556
Copy link
Member

base/power_monitor seems to handle suspend and resume events on windows https://source.chromium.org/chromium/chromium/src/+/master:base/power_monitor/power_monitor_device_source_win.cc . Can you verify if this is a broken behavior.

@codebytere
Copy link
Member Author

@deepak1556 looks like we can pretty easily use that approach too and support it - updated the PR. I also have suspend/resume support working for macOS but i'll put it in another PR.

@codebytere codebytere changed the title docs: document suspend/resume support feat: support suspend/resume on Windows Jun 23, 2020
@codebytere codebytere mentioned this pull request Jun 23, 2020
Merged
5 tasks
deepak1556
deepak1556 approved these changes Jun 23, 2020
View reviewed changes
Copy link
Member

@deepak1556 deepak1556 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Jun 24, 2020
@codebytere codebytere merged commit 6369748 into master Jun 24, 2020
@release-clerk
Copy link

release-clerk bot commented Jun 24, 2020

Release Notes Persisted

Added support for suspend and resume events to Windows.

@codebytere codebytere deleted the suspend-no-windows branch June 24, 2020 14:28
This was referenced Jun 24, 2020
Merged
Merged
Merged
@trop
Copy link
Contributor

trop bot commented Jun 24, 2020

I have automatically backported this PR to "10-x-y", please check out #24281

@trop
Copy link
Contributor

trop bot commented Jun 24, 2020

I have automatically backported this PR to "8-x-y", please check out #24282

@trop trop bot removed the target/8-x-y label Jun 24, 2020
@trop
Copy link
Contributor

trop bot commented Jun 24, 2020

I have automatically backported this PR to "9-x-y", please check out #24283

sentialx pushed a commit to sentialx/electron that referenced this pull request Jul 30, 2020
@codebytere @sentialx
feat: support suspend/resume on Windows (electron#24251)
63306ef
sentialx pushed a commit to sentialx/electron that referenced this pull request Apr 8, 2021
@codebytere @sentialx
feat: support suspend/resume on Windows (electron#24251)
37edfa7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zcbenz zcbenz zcbenz approved these changes

@deepak1556 deepak1556 deepak1556 approved these changes

@MarshallOfSound MarshallOfSound MarshallOfSound approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

powerMonitor does not fire 'suspend" event
4 participants
@codebytere @deepak1556 @zcbenz @MarshallOfSound