Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: isTrustedSender() in test-app #24214

Merged
merged 1 commit into from Jun 22, 2020
Merged

fix: isTrustedSender() in test-app #24214

merged 1 commit into from Jun 22, 2020

Conversation

miniak
Copy link
Contributor

@miniak miniak commented Jun 19, 2020 •
edited

Description of Change

Handles spaces and special characters in Electron path properly by using https://nodejs.org/api/url.html#url_url_fileurltopath_url.

Checklist

Release Notes

Notes: Fixed "null path-to-app" in test-app when Electron's path contains spaces or special characters.

@miniak miniak self-assigned this Jun 19, 2020
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Jun 19, 2020
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Jun 20, 2020
@alexeykuzmin alexeykuzmin merged commit 0629c6c into master Jun 22, 2020
@release-clerk
Copy link

release-clerk bot commented Jun 22, 2020

Release Notes Persisted

Fixed "null path-to-app" in test-app when Electron's path contains spaces or special characters.

@alexeykuzmin alexeykuzmin deleted the miniak/test-app branch June 22, 2020 12:14
This was referenced Jun 22, 2020
Closed
Merged
Merged
Merged
@trop
Copy link
Contributor

trop bot commented Jun 22, 2020

I have automatically backported this PR to "7-3-x", please check out #24229

@trop trop bot removed the target/7-3-x label Jun 22, 2020
@trop
Copy link
Contributor

trop bot commented Jun 22, 2020

I have automatically backported this PR to "10-x-y", please check out #24230

@trop trop bot added the in-flight/7-3-x label Jun 22, 2020
@trop
Copy link
Contributor

trop bot commented Jun 22, 2020

I have automatically backported this PR to "8-x-y", please check out #24231

@trop
Copy link
Contributor

trop bot commented Jun 22, 2020

I have automatically backported this PR to "9-x-y", please check out #24232

sentialx pushed a commit to sentialx/electron that referenced this pull request Jul 30, 2020
@miniak @sentialx
fix: isTrustedSender() in test-app (electron#24214)
9365fab
sentialx pushed a commit to sentialx/electron that referenced this pull request Apr 8, 2021
@miniak @sentialx
fix: isTrustedSender() in test-app (electron#24214)
c51e61f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexeykuzmin alexeykuzmin alexeykuzmin approved these changes

@deepak1556 deepak1556 deepak1556 approved these changes

@codebytere codebytere codebytere approved these changes

@nornagon nornagon Awaiting requested review from nornagon

@MarshallOfSound MarshallOfSound Awaiting requested review from MarshallOfSound

Assignees

@miniak miniak

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@miniak @alexeykuzmin @deepak1556 @codebytere