Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: let Node.js perform microtask checkpoint in the main process #24178

Merged
merged 1 commit into from Jun 17, 2020

Commits on Jun 17, 2020

  1. fix: let Node.js perform microtask checkpoint in the main process (#2…

    …4131)
    
    * fix: let Node.js perform microtask checkpoint in the main process
    
    * fix: don't specify v8::MicrotasksScope for explicit policy
    
    * fix: remove checkpoint from some call-sites
    
    We already perform checkpoint at the end of a task,
    either through MicrotaskRunner or through NodeBindings.
    There isn't a need to add them again when calling into JS
    except when dealing with promises.
    
    * fix: remove checkpoint from some call-sites
    
    We already perform checkpoint at the end of a task,
    either through MicrotaskRunner or through NodeBindings.
    There isn't a need to add them again when calling into JS
    except when dealing with promises.
    
    * fix incorrect specs
    
    * default constructor arguments are considered for explicit mark
    
    * add regression spec
    deepak1556 committed Jun 17, 2020
    Copy the full SHA
    ddee7bb View commit details
    Browse the repository at this point in the history