Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: expose sessionId in debugger module #24170

Merged
merged 1 commit into from Jul 2, 2020
Merged

Conversation

deepak1556
Copy link
Member

@deepak1556 deepak1556 commented Jun 17, 2020

Description of Change

Fixes #24168

Checklist

Release Notes

Notes: expose sessionId associated with a target from debugger module

@jkleinsc
Copy link
Contributor

@electron/wg-api reviewed and approved this at our June 29, 2020 meeting

@codebytere
Copy link
Member

(removing label as that label goes on the backports themselves ☝🏻)

@deepak1556
Copy link
Member Author

Approval ping :)

@nornagon
Copy link
Member

nornagon commented Jul 2, 2020

This is semver/minor, yes?

@deepak1556
Copy link
Member Author

yup thats right, will mark the backports. Thanks!

@deepak1556 deepak1556 merged commit d330c6f into master Jul 2, 2020
@release-clerk
Copy link

release-clerk bot commented Jul 2, 2020

Release Notes Persisted

expose sessionId associated with a target from debugger module

@deepak1556 deepak1556 deleted the robo/debugger_session branch July 2, 2020 20:04
@trop
Copy link
Contributor

trop bot commented Jul 2, 2020

I was unable to backport this PR to "8-x-y" cleanly;
you will need to perform this backport manually.

@trop
Copy link
Contributor

trop bot commented Jul 2, 2020

I have automatically backported this PR to "10-x-y", please check out #24397

@trop trop bot removed the target/10-x-y label Jul 2, 2020
@trop
Copy link
Contributor

trop bot commented Jul 2, 2020

I have automatically backported this PR to "9-x-y", please check out #24398

@trop
Copy link
Contributor

trop bot commented Jul 2, 2020

@deepak1556 has manually backported this PR to "8-x-y", please check out #24399

sentialx pushed a commit to sentialx/electron that referenced this pull request Jul 30, 2020
sentialx pushed a commit to sentialx/electron that referenced this pull request Apr 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Debugger API does not expose the sessionID from which CDP messages are received
4 participants