Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make pasteandmatchstyle accelerator os specific #24153

Merged
merged 1 commit into from Jun 17, 2020

Conversation

str4nge-4ttr4ctor
Copy link
Contributor

@str4nge-4ttr4ctor str4nge-4ttr4ctor commented Jun 16, 2020

Description of Change

Make pasteandmatchstyle accelerator OS specific: ‘Cmd+Option+Shift+V’ for macOS and ‘Shift+CommandOrControl+V’ for the other platforms. Previous behavior: ‘Shift+CommandOrControl+V’ used for all platforms (Mac, Windows, Linux).

Checklist

Release Notes

Notes: Fixed "Paste and Match Style" shortcut on macOS to match OS's "Option-Shift-Command-V"

@welcome
Copy link

welcome bot commented Jun 16, 2020

💖 Thanks for opening this pull request! 💖

We use semantic commit messages to streamline the release process. Before your pull request can be merged, you should update your pull request title to start with a semantic prefix.

Examples of commit messages with semantic prefixes:

  • fix: don't overwrite prevent_default if default wasn't prevented
  • feat: add app.isPackaged() method
  • docs: app.isDefaultProtocolClient is now available on Linux

Things that will help get your PR across the finish line:

  • Follow the JavaScript, C++, and Python coding style.
  • Run npm run lint locally to catch formatting errors earlier.
  • Document any user-facing changes you've made following the documentation styleguide.
  • Include tests when adding/changing behavior.
  • Include screenshots and animated GIFs whenever possible.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Jun 16, 2020
@alexeykuzmin
Copy link
Contributor

@str4nge-4ttr4ctor do you have links on how it works in Chromium or MS Word on macOS?

@str4nge-4ttr4ctor
Copy link
Contributor Author

str4nge-4ttr4ctor commented Jun 16, 2020

@str4nge-4ttr4ctor do you have links on how it works in Chromium or MS Word on macOS?

Based on the mac keyboard shortcuts, the shortcut for paste and match style in macOS is ‘Cmd+Option+Shift+V’ and not 'Shift+CommandOrControl+V'.

@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Jun 17, 2020
@alexeykuzmin alexeykuzmin merged commit 4e66f1b into electron:master Jun 17, 2020
@welcome
Copy link

welcome bot commented Jun 17, 2020

Congrats on merging your first pull request! 🎉🎉🎉

@release-clerk
Copy link

release-clerk bot commented Jun 17, 2020

Release Notes Persisted

Fixed "Paste and Match Style" shortcut on macOS to match OS's "Option-Shift-Command-V"

@trop
Copy link
Contributor

trop bot commented Jun 17, 2020

I have automatically backported this PR to "10-x-y", please check out #24182

@trop
Copy link
Contributor

trop bot commented Jun 17, 2020

I have automatically backported this PR to "7-3-x", please check out #24183

@trop
Copy link
Contributor

trop bot commented Jun 17, 2020

I have automatically backported this PR to "8-x-y", please check out #24184

@trop
Copy link
Contributor

trop bot commented Jun 17, 2020

I have automatically backported this PR to "9-x-y", please check out #24185

@miniak
Copy link
Contributor

miniak commented Jun 25, 2020

In Chromium the shortcut is just Cmd+Shift+V, which is more convenient that having to press 4 keys at once

sentialx pushed a commit to sentialx/electron that referenced this pull request Jul 30, 2020
sentialx pushed a commit to sentialx/electron that referenced this pull request Apr 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants