Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: fix MenuItem click handler type #24147

Merged
merged 1 commit into from Jun 17, 2020
Merged

docs: fix MenuItem click handler type #24147

merged 1 commit into from Jun 17, 2020

Conversation

codebytere
Copy link
Member

Description of Change

Closes #24144.

Corrects potentially undefined browserWindow in click handler for MenuItems.

Checklist

Release Notes

Notes: none.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Jun 16, 2020
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Jun 17, 2020
@codebytere codebytere merged commit a54fcde into master Jun 17, 2020
@release-clerk
Copy link

release-clerk bot commented Jun 17, 2020

Release Notes Persisted

none.

@codebytere codebytere deleted the fix-click-handler-type branch June 17, 2020 17:34
This was referenced Jun 17, 2020
Merged
Merged
Merged
@trop
Copy link
Contributor

trop bot commented Jun 17, 2020

I have automatically backported this PR to "10-x-y", please check out #24175

@trop
Copy link
Contributor

trop bot commented Jun 17, 2020

I have automatically backported this PR to "8-x-y", please check out #24176

@trop
Copy link
Contributor

trop bot commented Jun 17, 2020

I have automatically backported this PR to "9-x-y", please check out #24177

@trop trop bot added the merged/9-x-y label Jun 17, 2020
rafeca added a commit to say25/desktop that referenced this pull request Jul 16, 2020
@rafeca
Fix TypeScript errors
71e9ae6 
The type definitions for the menuItem were fixed to make the browserWindow undefined (see electron/electron#24147).  Good thing is that our code was already handling this case.
sentialx pushed a commit to sentialx/electron that referenced this pull request Jul 30, 2020
@codebytere @sentialx
docs: fix MenuItem click handler type (electron#24147)
55ddc0b
sentialx pushed a commit to sentialx/electron that referenced this pull request Apr 8, 2021
@codebytere @sentialx
docs: fix MenuItem click handler type (electron#24147)
33ca78b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarshallOfSound MarshallOfSound MarshallOfSound approved these changes

Assignees
No one assigned
Labels
documentation 📓
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TypeScript: MenuItem click handler is not typed
2 participants
@codebytere @MarshallOfSound