Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: let Node.js perform microtask checkpoint in the main process #24131

Merged
merged 7 commits into from Jun 17, 2020
Merged

fix: let Node.js perform microtask checkpoint in the main process #24131

merged 7 commits into from Jun 17, 2020

Commits on Jun 15, 2020

  1. fix: let Node.js perform microtask checkpoint in the main process

    @deepak1556
    deepak1556 committed Jun 15, 2020
    Configuration menu
    Copy the full SHA
    38669f8 View commit details
    Browse the repository at this point in the history

Commits on Jun 16, 2020

  1. fix: don't specify v8::MicrotasksScope for explicit policy

    @deepak1556
    deepak1556 committed Jun 16, 2020
    Configuration menu
    Copy the full SHA
    9b6ef9a View commit details
    Browse the repository at this point in the history

  2. fix: remove checkpoint from some call-sites 

    We already perform checkpoint at the end of a task,
either through MicrotaskRunner or through NodeBindings.
There isn't a need to add them again when calling into JS
except when dealing with promises.
    @deepak1556
    deepak1556 committed Jun 16, 2020
    Configuration menu
    Copy the full SHA
    40bace5 View commit details
    Browse the repository at this point in the history

  3. fix: remove checkpoint from some call-sites 

    We already perform checkpoint at the end of a task,
either through MicrotaskRunner or through NodeBindings.
There isn't a need to add them again when calling into JS
except when dealing with promises.
    @deepak1556
    deepak1556 committed Jun 16, 2020
    Configuration menu
    Copy the full SHA
    d706c0c View commit details
    Browse the repository at this point in the history

  4. fix incorrect specs

    @deepak1556
    deepak1556 committed Jun 16, 2020
    Configuration menu
    Copy the full SHA
    886d2bd View commit details
    Browse the repository at this point in the history

  5. default constructor arguments are considered for explicit mark

    @deepak1556
    deepak1556 committed Jun 16, 2020
    Configuration menu
    Copy the full SHA
    bf6e1c1 View commit details
    Browse the repository at this point in the history

  6. add regression spec

    @deepak1556
    deepak1556 committed Jun 16, 2020
    Configuration menu
    Copy the full SHA
    c094075 View commit details
    Browse the repository at this point in the history