fix: emit 'shutdown' outside -[NSApplication terminate:] #24111
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Closes #24105.
When macOS shuts down, Cocoa will send an
NSWorkspaceWillPowerOffNotification
followed by-[NSApplication terminate:]
. The original PR that added this on macOS hooked into the latter instead of the former, thereby creating the side effect that it would also be called when the app itself terminated.For more effective dx, this PR registers for
NSWorkspaceWillPowerOffNotification
and then emits'shutdown'
when the notification is sent instead.cc @zcbenz @deepak1556 @nornagon
Checklist
npm test
passesRelease Notes
Notes: Fixed an issue where
shutdown
would be emitted both on app and system shutdown on macOS.