fix: showing certificate dialog with no window #24091
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codebytere
force-pushed
the
fix-cert-dialog-no-window
branch
from
17ee739
to
6d8fd73
Compare
MarshallOfSound
approved these changes
Jun 12, 2020
|
Release Notes Persisted
|
This was referenced Jun 13, 2020
|
I have automatically backported this PR to "10-x-y", please check out #24118 |
|
I have automatically backported this PR to "7-3-x", please check out #24119 |
|
I have automatically backported this PR to "8-x-y", please check out #24120 |
|
I have automatically backported this PR to "9-x-y", please check out #24121 |
sentialx
pushed a commit
to sentialx/electron
that referenced
this pull request
Jul 30, 2020
sentialx
pushed a commit
to sentialx/electron
that referenced
this pull request
Apr 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Closes #24066.
Fixes an issue in
dialog.showCertificateTrustDialogwherewindowwas not explicitly set to null when no optional window was passed. This caused a converter error as theNativeWindowconverter doesn't know how to handleundefined. It's not possible to add a regression test for this case, unfortunately, as the cert trust dialog blocks the main process.cc @MarshallOfSound @ckerr @jkleinsc
Checklist
npm testpassesRelease Notes
Notes: Fixed an error when calling
dialog.showCertificateTrustDialogwith noBrowserWindow.