fix: assign session to remote webContents #23989
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sentialx
changed the title
sentialx
changed the title
stewartlord
approved these changes
Jun 9, 2020
| web_contents->SetUserAgentOverride(blink::UserAgentOverride::UserAgentOnly( | ||
| GetBrowserContext()->GetUserAgent()), | ||
| false); | ||
| Init(isolate); | ||
| AttachAsUserData(web_contents); | ||
| InitZoomController(web_contents, gin::Dictionary::CreateEmpty(isolate)); | ||
|
|
There was a problem hiding this comment.
Nit: needless whitespace change (and another one below)
zcbenz
approved these changes
Jun 11, 2020
|
Release Notes Persisted
|
|
I was unable to backport this PR to "9-x-y" cleanly; |
|
I have automatically backported this PR to "10-x-y", please check out #24064 |
sentialx
added a commit
to sentialx/electron
that referenced
this pull request
Jul 30, 2020
* fix: assign session to remote webContents * fix: test name
sentialx
added a commit
to sentialx/electron
that referenced
this pull request
Apr 8, 2021
* fix: assign session to remote webContents * fix: test name
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
This PR ensures that remote webContents (such as devtools and extension background pages) get initialized with
session_set.Could this be backported to 9-x-y and 10-x-y, please?
Closes #23615
Ref #19447
Checklist
npm testpassesRelease Notes
Notes: Fixed no
sessionin webContents of type remote.