build: fix for "enable_desktop_capturer = false" #23864
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexeykuzmin
force-pushed
the
alkuzmin/fix-enable-desktop-capturer-false
branch
3 times, most recently
from
e2d81aa
to
2948b93
Compare
alexeykuzmin
force-pushed
the
alkuzmin/fix-enable-desktop-capturer-false
branch
from
2948b93
to
d883fbe
Compare
miniak
approved these changes
Jun 1, 2020
jkleinsc
approved these changes
Jun 1, 2020
|
No Release Notes |
|
I was unable to backport this PR to "10-x-y" cleanly; |
alexeykuzmin
added a commit
that referenced
this pull request
Jun 1, 2020
(cherry picked from commit 4133c71)
|
@alexeykuzmin has manually backported this PR to "10-x-y", please check out #23876 |
jkleinsc
pushed a commit
that referenced
this pull request
Jun 1, 2020
|
/trop run backport-to 9-x-y |
|
The backport process for this PR has been manually initiated - |
|
I was unable to backport this PR to "9-x-y" cleanly; |
|
@deepak1556 has manually backported this PR to "9-x-y", please check out #23934 |
deepak1556
added a commit
that referenced
this pull request
Jun 7, 2020
…23934) * build: fix for "enable_desktop_capturer = false" (#23864) * build: fix filenames autogen with new BUILDFLAG syntax (#23952) * fix: default to NTLM v2 in the network service for POSIX platforms (#23846) * chore: update patch Co-authored-by: Alexey Kuzmin <alkuzmin@microsoft.com> Co-authored-by: Samuel Attard <sattard@slack-corp.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Some builds flags are not properly respected. Let's fix it.
Here are builds with
enable_desktop_capturer,enable_remote_module, andenable_views_apiset tofalsebefore the change:and after the change:
Checklist
npm testpassesRelease Notes
Notes: none