Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: nativeImage remote serialization #23796

Merged
merged 4 commits into from
May 28, 2020
Merged

fix: nativeImage remote serialization #23796

merged 4 commits into from
May 28, 2020

Commits on May 27, 2020

  1. fix: nativeImage remote serialization (#23543) 

    We weren't serializing nativeImages properly in the remote module, leading to gin conversion errors when trying to, for example, create a new context menu in the renderer with icons using nativeImage. This fixes that by adding a new special case to handle them.
    @codebytere
    codebytere committed May 27, 2020
    Configuration menu
    Copy the full SHA
    6ccc627 View commit details
    Browse the repository at this point in the history

  2. refactor: correctly serialize nativeImage/buffer with typeUtils (#23666) 

    * refactor: correctly serialize nativeImage/buffer with typeUtils

* test: add serialization specs

* fix: construct from dataURL

* test: test for dataURL specificity
    @codebytere
    codebytere committed May 27, 2020
    Configuration menu
    Copy the full SHA
    85201d3 View commit details
    Browse the repository at this point in the history

  3. refactor: use typeutils for nativeImage serialization (#23693)

    @codebytere
    codebytere committed May 27, 2020
    Configuration menu
    Copy the full SHA
    df0a26d View commit details
    Browse the repository at this point in the history

  4. fix: ensure nativeImage serialization main->renderer

    @codebytere
    codebytere committed May 27, 2020
    Configuration menu
    Copy the full SHA
    2a0343a View commit details
    Browse the repository at this point in the history