fix: only bezel frameless windows #23779
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkleinsc
approved these changes
May 26, 2020
leolabs
approved these changes
May 26, 2020
zcbenz
approved these changes
May 27, 2020
deepak1556
approved these changes
May 27, 2020
|
Release Notes Persisted
|
This was referenced May 27, 2020
|
I have automatically backported this PR to "10-x-y", please check out #23809 |
|
I have automatically backported this PR to "9-x-y", please check out #23810 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Closes #23767.
Previously we set bezeled corners on all windows when setting vibrancy regardless of their framelessness, and we should only be doing this when the window is specified to be frameless.
Before:
After:
cc @ckerr @jkleinsc @zcbenz
Checklist
npm testpassesRelease Notes
Notes: Fixed a bezeling issue on vibrant non-frameless BrowserWindows.