fix: weakly reference MenuModel from MenuController

[codebytere]

Description of Change

Refs:

• https://bugs.chromium.org/p/chromium/issues/detail?id=998835
• https://chromium-review.googlesource.com/c/chromium/src/+/1804538

Fixes a crash i've seen intermittently in Sentry on Catalina machines running Fiddle.

From the OG CL:

Before this CL, MenuController's contract required that the provided MenuModel outlived a MenuController instance. As of 10.15, it's impossible to fulfill that contract: AppKit seems to like keeping MenuController instances (via [NSMenuItem target]) alive until the next autorelease pool drain, and there's no way for the C++ code that creates & manages a MenuModel to know when that will happen.

This PR makes it such that ElectronMenuController holds a base::WeakPtr to its ElectronMenuModel, rather than a raw ptr, and handles the ElectronMenuModel being destroyed before the ElectronMenuController.

cc @MarshallOfSound @zcbenz

Checklist

• PR description included and stakeholders cc'd
• npm test passes
• PR title follows semantic commit guidelines
• PR release notes describe the change in a way relevant to app developers, and are capitalized, punctuated, and past tense.

Release Notes

Notes: Fixed an occasional menu crash on macOS Catalina when menu is closing.

[release-clerk]

Release Notes Persisted

Fixed an occasional menu crash on macOS Catalina when menu is closing.

[trop]

I have automatically backported this PR to "10-x-y", please check out #23806

[trop]

I have automatically backported this PR to "8-x-y", please check out #23807

[trop]

I have automatically backported this PR to "9-x-y", please check out #23808