Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: ensure nativeImage serialization main->renderer #23759

Merged
merged 1 commit into from
May 28, 2020
Merged

fix: ensure nativeImage serialization main->renderer #23759

merged 1 commit into from
May 28, 2020

Conversation

codebytere
Copy link
Member

Description of Change

Ensure that nativeImages are also serialized correctly when moving from main -> renderer. Note that this does not help with serialization over IPC, as we do not perform IPC serialization in JS and thus are bound by capabilities of the V8 Structured Clone Algorithm.

cc @miniak @nornagon @MarshallOfSound

Checklist

Release Notes

Notes: Fixed serialization of nativeImages over remote when moving from the main process to the renderer process.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label May 26, 2020
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label May 27, 2020
@codebytere codebytere mentioned this pull request May 27, 2020
Merged
@trop
Copy link
Contributor

trop bot commented May 27, 2020

@codebytere has manually backported this PR to "10-x-y", please check out #23794

@codebytere codebytere mentioned this pull request May 27, 2020
Merged
@trop
Copy link
Contributor

trop bot commented May 27, 2020

@codebytere has manually backported this PR to "9-x-y", please check out #23796

@codebytere codebytere mentioned this pull request May 27, 2020
Merged
@trop
Copy link
Contributor

trop bot commented May 27, 2020

@codebytere has manually backported this PR to "8-x-y", please check out #23797

@electron electron deleted a comment from trop bot May 27, 2020
@codebytere codebytere merged commit e8ea007 into master May 28, 2020
@release-clerk
Copy link

release-clerk bot commented May 28, 2020

Release Notes Persisted

Fixed serialization of nativeImages over remote when moving from the main process to the renderer process.

@codebytere codebytere deleted the ipc-main-renderer branch May 28, 2020 16:43
@ckerr ckerr mentioned this pull request Jun 8, 2020
Merged
6 tasks
@trop
Copy link
Contributor

trop bot commented Jun 8, 2020

@ckerr has manually backported this PR to "7-3-x", please check out #24021

@nornagon nornagon mentioned this pull request Oct 2, 2020
Closed
3 tasks
@bruceauyeung bruceauyeung mentioned this pull request Nov 26, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zcbenz zcbenz zcbenz approved these changes

@nornagon nornagon Awaiting requested review from nornagon

@MarshallOfSound MarshallOfSound Awaiting requested review from MarshallOfSound

@miniak miniak Awaiting requested review from miniak

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@codebytere @zcbenz