fix: trigger about panel for about role on win #23687
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codebytere
force-pushed
the
fix-about-role-windows
branch
from
2173ffe
to
7e7eb41
Compare
codebytere
changed the title
zcbenz
approved these changes
May 21, 2020
jkleinsc
approved these changes
May 21, 2020
|
Release Notes Persisted
|
|
/trop run backport |
|
The backport process for this PR has been manually initiated, here we go! :D |
This was referenced May 21, 2020
|
I have automatically backported this PR to "7-3-x", please check out #23713 |
|
I have automatically backported this PR to "8-x-y", please check out #23714 |
|
I have automatically backported this PR to "9-x-y", please check out #23715 |
|
/trop run backport-to 10-x-y |
|
The backport process for this PR has been manually initiated - |
|
I have automatically backported this PR to "10-x-y", please check out #23717 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Closes #23681.
Triggers
app.showAboutPanelon windows when a menuItem with theaboutrole is added, since Windows does not provide a default system about menu.cc @zcbenz @MarshallOfSound @jkleinsc @ckerr
Checklist
npm testpassesRelease Notes
Notes: Fixed an issue where the 'about' role had on effect on Windows menus.