refactor: correctly serialize nativeImage/buffer with typeUtils #23666
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codebytere
force-pushed
the
update-typeutils
branch
2 times, most recently
from
a045520
to
2c73974
Compare
codebytere
force-pushed
the
update-typeutils
branch
from
2c73974
to
19f3b0b
Compare
codebytere
force-pushed
the
update-typeutils
branch
from
19f3b0b
to
e95f0dc
Compare
MarshallOfSound
approved these changes
May 20, 2020
4 tasks
codebytere
added a commit
that referenced
this pull request
May 27, 2020
* refactor: correctly serialize nativeImage/buffer with typeUtils * test: add serialization specs * fix: construct from dataURL * test: test for dataURL specificity
|
@codebytere has manually backported this PR to "9-x-y", please check out #23796 |
codebytere
added a commit
that referenced
this pull request
May 27, 2020
* refactor: correctly serialize nativeImage/buffer with typeUtils * test: add serialization specs * fix: construct from dataURL * test: test for dataURL specificity
|
@codebytere has manually backported this PR to "8-x-y", please check out #23797 |
codebytere
added a commit
that referenced
this pull request
Jun 8, 2020
* fix: nativeImage remote serialization (#23543) We weren't serializing nativeImages properly in the remote module, leading to gin conversion errors when trying to, for example, create a new context menu in the renderer with icons using nativeImage. This fixes that by adding a new special case to handle them. * refactor: correctly serialize nativeImage/buffer with typeUtils (#23666) * refactor: correctly serialize nativeImage/buffer with typeUtils * test: add serialization specs * fix: construct from dataURL * test: test for dataURL specificity * refactor: use typeutils for nativeImage serialization * fix: ensure nativeImage serialization main->renderer * chore: fix FTBFS Co-authored-by: Charles Kerr <charles@charleskerr.com>
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Fixes an issue where Buffers and NativeImages were not being correctly serialized within
typeUtils. I plan to follow this PR with a slightly larger one that consolidates serialization and deserialization using this file, but that'll require some rethinking of how we track values and their types.cc @miniak @nornagon @MarshallOfSound
Checklist
npm testpassesRelease Notes
Notes: none