Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: nativeImage remote serialization #23635

Closed
wants to merge 4 commits into from
Closed

fix: nativeImage remote serialization #23635

wants to merge 4 commits into from

Conversation

trop[bot]
Copy link
Contributor

@trop trop bot commented May 18, 2020

Backport of #23543

See that PR for details.

Notes: Fixed an issue where nativeImages might throw conversion errors in the renderer process.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label May 18, 2020
@trop trop bot requested a review from codebytere May 18, 2020 16:29
@trop trop bot mentioned this pull request May 18, 2020
Merged
4 tasks
@trop trop bot added 9-x-y backport This is a backport PR labels May 18, 2020
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label May 18, 2020
zcbenz
zcbenz requested changes May 19, 2020
View reviewed changes
Copy link
Member

@zcbenz zcbenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Build is failing.

@codebytere
Copy link
Member

Doing in batch: #23796

@codebytere codebytere closed this May 27, 2020
@codebytere codebytere deleted the trop/9-x-y-bp-fix-nativeimage-remote-serialization-1589819384759 branch May 27, 2020 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zcbenz zcbenz zcbenz requested changes

@codebytere codebytere Awaiting requested review from codebytere

Assignees
No one assigned
Labels
9-x-y backport This is a backport PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@codebytere @zcbenz